From owner-cvs-all@FreeBSD.ORG Fri May 4 12:16:09 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AA05E16A402; Fri, 4 May 2007 12:16:09 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 4AEA513C447; Fri, 4 May 2007 12:16:09 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from outgoing.leidinger.net (p54A5EFC6.dip.t-dialin.net [84.165.239.198]) by redbull.bpaserver.net (Postfix) with ESMTP id 0F5112E0AE; Fri, 4 May 2007 14:16:01 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id ED3825B48A3; Fri, 4 May 2007 14:15:45 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.13.8/8.13.8/Submit) id l44CFjr6056547; Fri, 4 May 2007 14:15:45 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Fri, 04 May 2007 14:15:45 +0200 Message-ID: <20070504141545.8mis6w94gocw8408@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Fri, 04 May 2007 14:15:45 +0200 From: Alexander Leidinger To: Colin Percival References: <200705030433.l434XBvW005733@repoman.freebsd.org> <46397035.7000606@freebsd.org> <463A19D6.6070400@freebsd.org> In-Reply-To: <463A19D6.6070400@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.864, required 8, autolearn=not spam, BAYES_00 -15.00, DK_POLICY_SIGNSOME 0.00, FORGED_RCVD_HELO 0.14) X-BPAnet-MailScanner-From: alexander@leidinger.net X-Spam-Status: No Cc: cvs-src@freebsd.org, Tim Kientzle , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 12:16:09 -0000 Quoting Colin Percival (from Thu, 03 May 2007 10:20:22 -0700): > Tim Kientzle wrote: >> I wonder if it would be simpler to set non-zero exit only >> if this is the first path returned from tree_next() (which >> should be the path given on the command line). That >> would avoid the headache of having to perform a textual >> path comparison. >> >> A simple flag to indicate if this is the first time >> through the loop should suffice, I think. > > Hmm... I considered this, but I wasn't sure if there were any edge > cases where the first path returned by tree_next might not be the > path passed to tree_open; so I decided to take the route which I > knew would always work. What if someone gives more than one path to tar? Bye, Alexander. -- Put no trust in cryptic comments. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137