From owner-svn-src-all@FreeBSD.ORG Thu Jan 12 10:04:51 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 365F11065670; Thu, 12 Jan 2012 10:04:51 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail02.syd.optusnet.com.au (mail02.syd.optusnet.com.au [211.29.132.183]) by mx1.freebsd.org (Postfix) with ESMTP id B26E38FC1B; Thu, 12 Jan 2012 10:04:50 +0000 (UTC) Received: from c211-30-171-136.carlnfd1.nsw.optusnet.com.au (c211-30-171-136.carlnfd1.nsw.optusnet.com.au [211.30.171.136]) by mail02.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id q0C9rUAq009034 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 12 Jan 2012 20:54:02 +1100 Date: Thu, 12 Jan 2012 20:53:30 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Guy Helmer In-Reply-To: <201201112245.q0BMjFYr080049@svn.freebsd.org> Message-ID: <20120112205016.X1000@besplex.bde.org> References: <201201112245.q0BMjFYr080049@svn.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r229988 - head/lib/libutil X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2012 10:04:51 -0000 On Wed, 11 Jan 2012, Guy Helmer wrote: > Log: > Fix prototype formatting (indentation, long lines, and continued lines). > > Requested by bde. Thanks. This looks good. Here are a few more fixes (mostly prototype :ormatting, 2 lines struct member formatting and 1 and 1 missing underscore). % Index: libutil.h % =================================================================== % RCS file: /home/ncvs/src/lib/libutil/libutil.h,v % retrieving revision 1.64 % diff -u -r1.64 libutil.h % --- libutil.h 11 Jan 2012 22:45:15 -0000 1.64 % +++ libutil.h 12 Jan 2012 09:49:29 -0000 % @@ -69,8 +69,8 @@ % /* for properties.c */ % typedef struct _property { % struct _property *next; % - char *name; % - char *value; % + char *name; % + char *value; % } *properties; % % #ifdef _SYS_PARAM_H_ % @@ -121,7 +121,7 @@ % void properties_free(properties _list); % char *property_find(properties _list, const char *_name); % properties % - properties_read(int fd); % + properties_read(int _fd); % int realhostname(char *_host, size_t _hsize, const struct in_addr *_ip); % int realhostname_sa(char *_host, size_t _hsize, struct sockaddr *_addr, % int _addrlen); % @@ -139,8 +139,10 @@ % #endif % % #ifdef _PWD_H_ % -int pw_copy(int _ffd, int _tfd, const struct passwd *_pw, struct passwd *_old_pw); % -struct passwd *pw_dup(const struct passwd *_pw); % +int pw_copy(int _ffd, int _tfd, const struct passwd *_pw, % + struct passwd *_old_pw); % +struct passwd % + *pw_dup(const struct passwd *_pw); % int pw_edit(int _notsetuid); % int pw_equal(const struct passwd *_pw1, const struct passwd *_pw2); % void pw_fini(void); % @@ -149,21 +151,26 @@ % char *pw_make_v7(const struct passwd *_pw); % int pw_mkdb(const char *_user); % int pw_lock(void); % -struct passwd *pw_scan(const char *_line, int _flags); % -const char *pw_tempname(void); % +struct passwd % + *pw_scan(const char *_line, int _flags); % +const char % + *pw_tempname(void); % int pw_tmp(int _mfd); % #endif % % #ifdef _GRP_H_ % -int gr_copy(int __ffd, int _tfd, const struct group *_gr, struct group *_old_gr); % -struct group *gr_dup(const struct group *_gr); % +int gr_copy(int __ffd, int _tfd, const struct group *_gr, % + struct group *_old_gr); % +struct group % + *gr_dup(const struct group *_gr); % int gr_equal(const struct group *_gr1, const struct group *_gr2); % void gr_fini(void); % int gr_init(const char *_dir, const char *_master); % int gr_lock(void); % char *gr_make(const struct group *_gr); % int gr_mkdb(void); % -struct group *gr_scan(const char *_line); % +struct group % + *gr_scan(const char *_line); % int gr_tmp(int _mdf); % #endif % Bruce