From owner-dev-commits-ports-all@freebsd.org Thu Jun 3 10:12:00 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A0AB06562E3; Thu, 3 Jun 2021 10:12:00 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FwhX04893z4n7H; Thu, 3 Jun 2021 10:12:00 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from mail.j.mat.cc (owncloud.cube.mat.cc [IPv6:2a01:678:4:1::228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 61D77F276; Thu, 3 Jun 2021 10:12:00 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:678:ab:0:3356:ef6b:256f:d0c6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 3626E942D80; Thu, 3 Jun 2021 10:11:59 +0000 (UTC) Date: Thu, 3 Jun 2021 12:11:57 +0200 From: Mathieu Arnold To: Torsten Zuehlsdorff Cc: Gerald Pfeifer , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: Replacing USE_GCC=any and the danfe@ filter (was: svn commit: r568012 - head/net/tightvnc) Message-ID: <20210603101157.noqag2ace5pcz6pu@aching.in.mat.cc> References: <20210603063235.676vy42y56fzvuu5@aching.in.mat.cc> <64998e65-5200-ba36-eb61-f54b26a6e2a8@toco-domains.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kizcpyg7xc4c4hd7" Content-Disposition: inline In-Reply-To: <64998e65-5200-ba36-eb61-f54b26a6e2a8@toco-domains.de> X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jun 2021 10:12:00 -0000 --kizcpyg7xc4c4hd7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 03, 2021 at 11:50:54AM +0200, Torsten Zuehlsdorff wrote: >=20 >=20 > On 03.06.21 08:32, Mathieu Arnold wrote: > > On Thu, Jun 03, 2021 at 12:22:47AM +0200, Gerald Pfeifer wrote: > > > On Sun, 30 May 2021, Mathieu Arnold wrote: > > > > Thank you for working on this. > > >=20 > > > So, I was just ready to commit the next step and prepared a nice git > > > style commit message: > > >=20 > > > Replace USE_GCC=3Dany with USE_GCC=3Dyes > > > USE_GCC=3Dany has been equivalent to USE_GCC=3Dyes in most cases = (such > > > as i386 and amd64 since 12.x and depending on configuration 11.x, > > > most newer installations on other platforms, and 13.x across the > > > board). > > > Since commit 96c17633d90386b5bcf8 Mk/bsd.gcc.mk ... > > >=20 > > > Alas, the danfe@ filter struck: > > >=20 > > > remote: Resolving deltas: 100% (111/111), completed with 111 loca= l objects. > > > remote: > > > remote: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > remote: First line does not start with the regular > > > remote: category/port: subject > > > remote: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > >=20 > > > What now? > > >=20 > > > Neither "*/*: Replace USE_GCC=3Dany..." in the subject nor a couple d= ozen > > > individual commits strike me as desirable. > >=20 > > *: Replace... works just fine. >=20 > This seems to be a transcription of "It works around a rule which has its > purpose but should not be enforced 100% of the time". Well, no, the subject of all commits has to have a "discriminator" to tell people scanning commits what a commit is about. Having '*:' or '*/*:' for commits that span many ports is also fine, it does not defeats the rule, it acts as the discriminator saying that it's not about a specific port, but a change, like a framework sweep. --=20 Mathieu Arnold --kizcpyg7xc4c4hd7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAmC4quhfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgKw/Q/9EekEaj9mlkYv+OUTCUC5A4MzIk4k7Tb1WpEqaXTaFCWnTM9JCyxEpfFl PIKGBDVYejLYxqMs8/2zAcy5mtoJEJmyVGxgMiP27wE+m3peDjzHlJk74Bxgenlr wzWJqPVxzMifY8yalFvJ3v+xQ8CuNaUrU/Mht7Vrnki217ZgCG1jbr0L7vNb82T9 97IRKp91yaJdhx+ULYD3mmQ7e71wfGSPJTN+t/nZd0g/nAckjHF0YOOcTk+lSZcp nvQokKdPeh7htjr/CT2T96DLgF1tweVZfJRVS7Gu84sMioLBs4NFz9nD367Q09Fb j5wiTqRYaes+GafSkj5tGER3kNZ2OWkKmGPqk0cvMk/qA2Tt1nfwqfO7qYU7Gx+j JS81lpDKhBKeZkD0CHFykrxD27LCwD/tSPQIj43NJXaaVMvbIQRgl/ET1Q5ZPbAw bkzkDCS4aOJY61F1YP44tnFHPLwhTTchc++OUcg0h+PEWV4ojMiWaj2oIc5LoRzV 68kv24kf9GsBX3Dw2jyZDE0IMt7HKgE3EM/hzZswePLsouJLv82i7ikMdtiO1fvT Y5Rn15I5mYc0zdp5VqJ+eYsvoZMwxmHsZ0UeBxWvPkNwcIvm83HaIArkwdGFBVyv CqjXnfR4KWgTPnJ3KMrOCTO9418XQA91f5qovPK+JjTwzenPYnU= =d+lv -----END PGP SIGNATURE----- --kizcpyg7xc4c4hd7--