From owner-freebsd-arch Tue Jan 15 6:39:51 2002 Delivered-To: freebsd-arch@freebsd.org Received: from point.osg.gov.bc.ca (point.osg.gov.bc.ca [142.32.102.44]) by hub.freebsd.org (Postfix) with ESMTP id 3B1C337B41F for ; Tue, 15 Jan 2002 06:39:33 -0800 (PST) Received: (from daemon@localhost) by point.osg.gov.bc.ca (8.8.7/8.8.8) id GAA17347; Tue, 15 Jan 2002 06:35:13 -0800 Received: from passer.osg.gov.bc.ca(142.32.110.29) via SMTP by point.osg.gov.bc.ca, id smtpda17337; Tue Jan 15 06:34:55 2002 Received: (from uucp@localhost) by passer.osg.gov.bc.ca (8.11.6/8.9.1) id g0FEYoK30450; Tue, 15 Jan 2002 06:34:50 -0800 (PST) Received: from UNKNOWN(10.1.2.1), claiming to be "cwsys.cwsent.com" via SMTP by passer9.cwsent.com, id smtpdK30440; Tue Jan 15 06:34:48 2002 Received: (from uucp@localhost) by cwsys.cwsent.com (8.11.6/8.9.1) id g0FEYlK72569; Tue, 15 Jan 2002 06:34:47 -0800 (PST) Message-Id: <200201151434.g0FEYlK72569@cwsys.cwsent.com> Received: from localhost.cwsent.com(127.0.0.1), claiming to be "cwsys" via SMTP by localhost.cwsent.com, id smtpdL72556; Tue Jan 15 06:34:44 2002 X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 Reply-To: Cy Schubert - ITSD Open Systems Group From: Cy Schubert - ITSD Open Systems Group X-Sender: schubert To: Poul-Henning Kamp Cc: Max Khon , arch@FreeBSD.ORG Subject: Re: request for review In-reply-to: Your message of "Tue, 15 Jan 2002 11:53:46 +0100." <19068.1011092026@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 15 Jan 2002 06:34:44 -0800 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In addition to making FreeBSD consistent with OpenBSD and Linux, as stated by the originator of this thread, the patch also makes FreeBSD consistent with Solaris and Tru64-UNIX. I'm for it. Regards, Phone: (250)387-8437 Cy Schubert Fax: (250)387-5766 Team Leader, Sun/Alpha Team Email: Cy.Schubert@osg.gov.bc.ca Open Systems Group, ITSD Ministry of Management Services Province of BC FreeBSD UNIX: cy@FreeBSD.org In message <19068.1011092026@critter.freebsd.dk>, Poul-Henning Kamp writes: > > I think it is bogus for devices other than disks to flout a > va_blocksize, but I am on the other hand not sure what the > relevant (if any) standards say. > > If this patch makes things better, I'm all for it. > > Poul-Henning > > In message <20020115031901.A99067@iclub.nsu.ru>, Max Khon writes: > > > >--qDbXVdCdHGoSgWSk > >Content-Type: text/plain; charset=us-ascii > >Content-Disposition: inline > > > >hi, there! > > > >please review attached patch. it should fix `diff' when one of the > >compared files is a tty (e.g. 'diff -u - /etc/motd'). > >The problem is that fstat(0, &s) returns s.st_blocksize == 0 in this case > >and this breaks `diff'. > > > >I do not know if this is correct fix (should `diff' be fixed instead?) > >but under OpenBSD 2.9 and Linux 2.2.x non-zero values are returned. > > > >/fjoe > > > >--qDbXVdCdHGoSgWSk > >Content-Type: text/plain; charset=us-ascii > >Content-Disposition: attachment; filename="vfs_vnops.c.diff" > > > >? current-diffs > >Index: vfs_vnops.c > >=================================================================== > >RCS file: /home/ncvs/src/sys/kern/vfs_vnops.c,v > >retrieving revision 1.125 > >diff -u -p -r1.125 vfs_vnops.c > >--- vfs_vnops.c 18 Dec 2001 20:48:54 -0000 1.125 > >+++ vfs_vnops.c 14 Jan 2002 18:04:45 -0000 > >@@ -579,6 +579,8 @@ vn_stat(vp, sb, td) > > sb->st_blksize = vp->v_rdev->si_bsize_phys; > > if (sb->st_blksize < BLKDEV_IOSIZE) > > sb->st_blksize = BLKDEV_IOSIZE; > >+ } else if (vap->va_type == VCHR) { > >+ sb->st_blksize = vap->va_blocksize; > > } else { > > sb->st_blksize = 0; > > } > > > >--qDbXVdCdHGoSgWSk-- > > > >To Unsubscribe: send mail to majordomo@FreeBSD.org > >with "unsubscribe freebsd-arch" in the body of the message > > > > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > phk@FreeBSD.ORG | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-arch" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message