From owner-freebsd-hackers@FreeBSD.ORG Wed Mar 19 15:21:39 2014 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6B568417 for ; Wed, 19 Mar 2014 15:21:39 +0000 (UTC) Received: from mail-pb0-f41.google.com (mail-pb0-f41.google.com [209.85.160.41]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 3F458615 for ; Wed, 19 Mar 2014 15:21:39 +0000 (UTC) Received: by mail-pb0-f41.google.com with SMTP id jt11so9036458pbb.14 for ; Wed, 19 Mar 2014 08:21:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=WSwpuOsl3N3H7wtLHvoSiotvgZ8Vxzo6PF/28xswJp0=; b=Swv7Fk4I8C+zJGO7mLejxN7IADzvLxal8FudjooGVXLWRkkIg6mCPxy3rfFANczMOz +/s56/Cl/g34JMREAfWSbkiFizBiy86K5T4hKeFfRgthY9C9PHFx1YW6f25AoYev12hn vCtzbYBUjfwc3JPrF1DCcCbwelxMZpyTafGig35Jb2uz9yMhjGHgwUiL8cmuSNY2og5F jpT+S3IG9zUyBiD7FfUM+HrFDFHOE0astSW7UdR1jEtn7HmPfjF0ywIdtwpgZzofP8qu PMky5oVmC6xCxwz4fwOWtUFzHJXK7VqSSofoKYwj4cxQGDn53bZyY1PKPSy+QA/GFnK7 H5NQ== X-Gm-Message-State: ALoCoQnnmkSDHW/ApmN5Wljc8hjbGjOiGvtt5I5Qj8h/mEB/h+2rhzHULsRsJK1ewEPOARhgnvxW X-Received: by 10.68.110.165 with SMTP id ib5mr40250496pbb.61.1395242492931; Wed, 19 Mar 2014 08:21:32 -0700 (PDT) Received: from bsdimp.corp.netflix.com ([69.53.237.72]) by mx.google.com with ESMTPSA id x5sm63240878pbw.26.2014.03.19.08.21.31 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 19 Mar 2014 08:21:32 -0700 (PDT) Sender: Warner Losh Subject: Re: [RFC] Install world with external toolcahin: need add STRIPBIN to IMAKEENV Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Content-Type: text/plain; charset=windows-1252 From: Warner Losh X-Priority: 3 (Normal) In-Reply-To: <1541075262.20140319154209@serebryakov.spb.ru> Date: Wed, 19 Mar 2014 08:21:31 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <1541075262.20140319154209@serebryakov.spb.ru> To: lev@FreeBSD.org X-Mailer: Apple Mail (2.1874) Cc: freebsd-hackers@freebsd.org, freebsd-current@FreeBSD.org X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Mar 2014 15:21:39 -0000 On Mar 19, 2014, at 4:42 AM, Lev Serebryakov wrote: > Hello, Freebsd-current. >=20 > To make "make installworld" successfull with external toolchain (with > WITHOUT_BINUTILS-built world) we need to have STRIBIN, pointing to > working "strip" in environment, or "install -s" will fail. Assuming you meant STRIPBIN here... > Does attached patch looks good? Yes. This looks good to my eye. I have a very similar change in my tree from a while ago where I tried to get external toolchain support working with non-clang compilers. I=92ll have to go find that tree=85 So please go ahead and commit this if you don=92t get any objections... > Unfortunately, "STRIP" variable is occuped by "-s" flag :( A historical accident=85 but one we=92re rather stuck with... Warner