From owner-cvs-all  Fri Sep  6 15: 2:38 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1B73D37B400; Fri,  6 Sep 2002 15:02:32 -0700 (PDT)
Received: from baraca.united.net.ua (ns.united.net.ua [193.111.8.193])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 179C143E4A; Fri,  6 Sep 2002 15:02:28 -0700 (PDT)
	(envelope-from max@vega.com)
Received: from vega.vega.com (xDSL-2-2.united.net.ua [193.111.9.226])
	by baraca.united.net.ua (8.11.6/8.11.6) with ESMTP id g86M1xs48231;
	Sat, 7 Sep 2002 01:02:00 +0300 (EEST)
	(envelope-from max@vega.com)
Received: from vega.vega.com (max@localhost [127.0.0.1])
	by vega.vega.com (8.12.5/8.12.5) with ESMTP id g86M1sdO002766;
	Sat, 7 Sep 2002 01:01:54 +0300 (EEST)
	(envelope-from sobomax@FreeBSD.org)
Received: (from max@localhost)
	by vega.vega.com (8.12.5/8.12.5/Submit) id g86M1kt6002765;
	Sat, 7 Sep 2002 01:01:46 +0300 (EEST)
Date: Sat, 7 Sep 2002 01:01:46 +0300
From: Maxim Sobolev <sobomax@FreeBSD.ORG>
To: Peter Wemm <peter@wemm.org>
Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/net if_gre.c if_gre.h src/sys/netinet ip_gre.c
Message-ID: <20020906220146.GA2737@vega.vega.com>
References: <200209061816.g86IG3ni003518@freefall.freebsd.org> <20020906211015.A381C2A7D6@canning.wemm.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20020906211015.A381C2A7D6@canning.wemm.org>
User-Agent: Mutt/1.4i
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Fri, Sep 06, 2002 at 02:10:15PM -0700, Peter Wemm wrote:
> Maxim Sobolev wrote:
> > sobomax     2002/09/06 11:16:03 PDT
> > 
> >   Modified files:
> >     sys/net              if_gre.c if_gre.h 
> >     sys/netinet          ip_gre.c 
> >   Log:
> >   Reduce namespace pollution by staticizing everything, which doesn't need to
> >   be visible from outside of the module.
> 
> This seems to break kdump:
> 
> ===> usr.bin/kdump
> cc -O -pipe  -I/home/src/usr.bin/kdump/../ktrace -I/home/src/usr.bin/kdump/../..    -c /home/src/usr.bin/kdump/kdump.c
> cc -O -pipe  -I/home/src/usr.bin/kdump/../ktrace -I/home/src/usr.bin/kdump/../..    -c ioctl.c
> In file included from ioctl.c:63:
> /usr/obj/home/src/i386/usr/include/net/if_gre.h:89: field `gi_i' has incomplete type
> /usr/obj/home/src/i386/usr/include/net/if_gre.h:133: field `mi' has incomplete type

Hmm, I suspect that actually broken is mkioctls, which have absolutely
no reason to generate #include <net/if_gre.h>. In any case, I've committed
a fix which should workaround the problem. Please let me know if it
didn't help.

-Maxim

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message