From owner-freebsd-fs@FreeBSD.ORG Sun Nov 20 18:10:22 2011 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5A37A1065674; Sun, 20 Nov 2011 18:10:22 +0000 (UTC) (envelope-from florian@wagner-flo.net) Received: from umbracor.wagner-flo.net (umbracor.wagner-flo.net [213.165.81.202]) by mx1.freebsd.org (Postfix) with ESMTP id 140D28FC13; Sun, 20 Nov 2011 18:10:22 +0000 (UTC) Received: from naclador.mos32.de (ppp-88-217-37-245.dynamic.mnet-online.de [88.217.37.245]) by umbracor.wagner-flo.net (Postfix) with ESMTPSA id F05333C065AE; Sun, 20 Nov 2011 19:10:20 +0100 (CET) Date: Sun, 20 Nov 2011 19:10:18 +0100 From: Florian Wagner To: Andriy Gapon Message-ID: <20111120191018.1aa4e882@naclador.mos32.de> In-Reply-To: <4EC91B36.7060107@FreeBSD.org> References: <20111015214347.09f68e4e@naclador.mos32.de> <4E9ACA9F.5090308@FreeBSD.org> <20111019082139.1661868e@auedv3.syscomp.de> <4E9EEF45.9020404@FreeBSD.org> <20111019182130.27446750@naclador.mos32.de> <4EB98E05.4070900@FreeBSD.org> <20111119211921.7ffa9953@naclador.mos32.de> <4EC8CD14.4040600@FreeBSD.org> <20111120121248.5e9773c8@naclador.mos32.de> <4EC91B36.7060107@FreeBSD.org> X-Mailer: Claws Mail 3.7.10 (GTK+ 2.24.5; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/lQHAnqhkx7QehUPPqv6_9XE"; protocol="application/pgp-signature" Cc: freebsd-fs@FreeBSD.org Subject: Re: Extending zfsboot.c to allow selecting filesystem from boot.config X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Nov 2011 18:10:22 -0000 --Sig_/lQHAnqhkx7QehUPPqv6_9XE Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 20 Nov 2011 17:22:30 +0200 Andriy Gapon wrote: > I think that the most straightforward way would be to checkout > tools/tools/zfsboottest from head, copy it into a same named > directory under stable/8, make it and run it. I did just that: # make MACHINE_CPUARCH=3Damd64 Warning: Object directory not changed from original /usr/src/stable-8/tools= /tools/zfsboottest cc -O1 -I/usr/src/stable-8/tools/tools/zfsboottest/../../../sys/boot/zfs -= I/usr/src/stable-8/tools/tools/zfsboottest/../../../sys/cddl/boot/zfs -I. = -fdiagnostics-show-option -W -Wextra -Wno-sign-compare -Wno-unused-parame= ter -Werror -std=3Dgnu99 -fstack-protector -c zfsboottest.c In file inclu= ded from /usr/include/sys/param.h:70, from zfsboottest.c:30: /usr/include/sys/types.h:146: error: expected '=3D', ',', ';', 'asm' or '__= attribute__' before 'cpumask_t' In file included from ./machine/param.h:36, from /usr/include/sys/param.h:116, from zfsboottest.c:30: ./machine/_align.h:6:24: error: x86/_align.h: No such file or directory cc1: warnings being treated as errors zfsboottest.c: In function 'main': zfsboottest.c:141: warning: implicit declaration of function 'zfs_mount_poo= l' zfsboottest.c:148: warning: passing argument 1 of 'zfs_lookup' from incompa= tible pointer type zfsboottest.c:154: warning: passing argument 1 of 'zfs_dnode_stat' from inc= ompatible pointer type After look around a bit I found _types.h and param.h in the machine subdirectory of zfsboottest. They get included from headers in /usr/include because of the "-I.". After renaming them only the errors about zfs_mount_pool and the incompatible pointer types are left. Which make sense to me as this is stuff changed in your patches. Regards Florian Wagner --Sig_/lQHAnqhkx7QehUPPqv6_9XE Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iEYEARECAAYFAk7JQooACgkQLvW/2gp2pPwROACdHiQ+WTvBb4JOTeQUZ8drfnO8 XQIAnAk/77v4ggAhkwT9FGVZUfmJgxKK =pCQn -----END PGP SIGNATURE----- --Sig_/lQHAnqhkx7QehUPPqv6_9XE--