From owner-svn-ports-head@freebsd.org Tue Jul 2 10:44:15 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A51DA15CF29E; Tue, 2 Jul 2019 10:44:15 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 40B918015F; Tue, 2 Jul 2019 10:44:15 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 1489FD398; Tue, 2 Jul 2019 10:44:15 +0000 (UTC) Date: Tue, 2 Jul 2019 10:44:15 +0000 From: Alexey Dokuchaev To: Baptiste Daroussin Cc: Piotr Kubaj , Greg Lewis , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r505640 - head/java/openjdk11 Message-ID: <20190702104415.GB59302@FreeBSD.org> References: <201907012118.x61LIIQr011692@repo.freebsd.org> <20190702072450.GA17073@KGPE-D16> <20190702082607.GA45590@FreeBSD.org> <20190702083515.seykaqqjd77zyyr2@ivaldir.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190702083515.seykaqqjd77zyyr2@ivaldir.net> User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: 40B918015F X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.94)[-0.938,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jul 2019 10:44:15 -0000 On Tue, Jul 02, 2019 at 10:35:15AM +0200, Baptiste Daroussin wrote: > On Tue, Jul 02, 2019 at 08:26:08AM +0000, Alexey Dokuchaev wrote: > > On Tue, Jul 02, 2019 at 09:24:50AM +0200, Piotr Kubaj wrote: > > > Why not use USES=compiler:c11 instead of setting manually USE_GCC=yes? > > > > Technically they're semantically not the same; while pulling C11-capable > > compiler might fix the problem, you're still telling the reader that > > you're pulling C11-capable compiler, while USE_GCC means that you want > > GCC, devoid of particular reasons. > > > > In practice, compiler:c11 often used as compiler:modern. [...] > > Actually the majority of addition of compiler:c11 are wrong (from the one > I have been able to check) I tend to agree. :( > It would be really nice to stop blindy using compiler:c11 ;) Right; unfortunately, often people who commit these changes do not bother to check with the actual code to see if a different/better solution is available (or even in order). ./danfe