From nobody Sat Aug 23 06:59:07 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c87Fr0rWcz65RSW; Sat, 23 Aug 2025 06:59:12 +0000 (UTC) (envelope-from gbe@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c87Fp3m5Cz3Mpy; Sat, 23 Aug 2025 06:59:10 +0000 (UTC) (envelope-from gbe@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755932350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iiWIs0hacWnJQwhuG09DT06MHhhAwFG0p4n/jYWld9E=; b=Cci+MsamTd15S/MmeonluPk3Doch3bVV56o38W3is8uq6bSVayN5c6BR6lRgGGiiND4/gT 2sBq2gDKff1ow85P4eSOm0Wy65HiYLWKwNhQytw+CuUWNqKIeI4pogfi9EzBuLAI4UH0uO lrPkT9EKTwaH+C4vhX0IdG6VQ4psNKbPofAml+teqGYG8y6qUVcplM1qbiJUctPt8+I1HB Hy6V+ipRAgKeyt90EMRQTmYPvt7myubkdktr4hasatSYWOMhQCjUvSpU0LMHZpNsPNCTH6 h7Ns+T53tnQveEsGDkwvICU7+0PNN0a+c/uwaiphAbeHIUPwv4tNSn9Wt2Z6yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755932350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iiWIs0hacWnJQwhuG09DT06MHhhAwFG0p4n/jYWld9E=; b=A611kSdk3sqltdULVK3EjDgGD3M8HYpqW9VVZ4T+SjM6A08riPZIKOPt4Oi4w/oigCvmvN xfcyuYVEgJwM5PUnD15RGrUiWrJEzktxxZ4m4OLM96v/vpeZRXfRYYWB5hACU2AZkwrINq bisY9MZhWx1wLlLUAosZUBu3qKWFkFipRcFtL1vyWjZcm83pXH2MEcqfvXfjr/JCYK3CYN Bv+bPi1MFJDSsp+EHOAWG7JLzZfAPD55k9frRnSYnY1b0NibA6+SOGS9qKXc9uBzMuxJIK qbCikPDE6NF9Pwe5eyVIqXYotRrDaxySymRGSiUUuAQtSFR9qMfqGAFIdAZ2Hw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1755932350; a=rsa-sha256; cv=none; b=fisIXcN3c5w7XnjborCzR6zIXtqI8OXRsBkbw3D7BnWCETQLFlY3skXRJKWiTkoUpkwbov u/lxeBA/qJiQCp7mkQvEcqTA85z8GyE3pcuEB9L2KpDIFXzIwaq1NvSo2qxjLueN8aaPJM 0ZXPKxbOqv/JH2j9Grk+1G4FnDuKQfVuFbocQOEZ5HBmbM/KQstbN87a/MVts/TH+xuQAl yA89xIXmDCetsZtuY5t9qWGbqIRyosTuWqVpEsg9YNsucJ6dEdlu51aOA2vrf41oBOyaFq JBf7diH2bSW6e5GXBDFsLn0ciuX4IiW9iDh2ayq5MrdgV4gmcdZgAlFu7YXtjA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from localhost (p4fd8b8c9.dip0.t-ipconnect.de [79.216.184.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gbe) by smtp.freebsd.org (Postfix) with ESMTPSA id 4c87Fp0XCRz1ClH; Sat, 23 Aug 2025 06:59:09 +0000 (UTC) (envelope-from gbe@FreeBSD.org) Date: Sat, 23 Aug 2025 08:59:07 +0200 From: Gordon Bergling To: ShengYi Hung Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 1685192ea1fa - main - hkbd: remove erorr detection in KDSKBSTATE ioctl Message-ID: References: <202508230450.57N4oxwG023161@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IBVGbubFc4T8ux6L" Content-Disposition: inline In-Reply-To: <202508230450.57N4oxwG023161@gitrepo.freebsd.org> X-Url: X-Operating-System: Darwin 24.6.0 arm64 X-Host-Uptime: 8:54 up 2 days, 11:50, 3 users, load averages: 1.50 2.44 4.63 --IBVGbubFc4T8ux6L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi ShengYi, On Sat, Aug 23, 2025 at 04:50:59AM +0000, ShengYi Hung wrote: > The branch main has been updated by aokblast: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D1685192ea1faac28f2d4feede5= 3e70b6a380500f >=20 > commit 1685192ea1faac28f2d4feede53e70b6a380500f > Author: ShengYi Hung > AuthorDate: 2025-08-21 17:59:15 +0000 > Commit: ShengYi Hung > CommitDate: 2025-08-23 04:50:09 +0000 >=20 > hkbd: remove erorr detection in KDSKBSTATE ioctl > =20 > The KDSKBSTATE ioctl brings the LED up. However, some keyboards (like= qemu > keyboard) may not have LED or failed to set the LED due to unexpected= reason. > Therefore, removing the error check as ukbd(4) does allow the keyboar= d works > correctly with kbdcontrol(4). > =20 > Also move hw.hid.hkbd.no_leds sysctl out of HID_BUG thus users can > disable setting LEDs > =20 > PR: 288968 > Reviewed by: wulf > Tested by: trashcan@ellael.org, marklmi26-fbsd@yahoo.com, trkell= ers@gmail.coom > Approved by: lwsu (mentor), markj (mentor) > MFC after 1 week > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D52101 > =20 > mvalsmva > --- I am not sure how this is related, but since that commit, buildkernel of GE= NERIC is broken both on amd64 and aarch64. The following error is from an amd64 build, aarch64 i= s the same. ----------------------------- /storage/freebsd/src/current/sys/dev/hid/hkbd.c:1831:10: error: called ob= ject type 'char[5]' is not a function or function pointer 1831 | DPRINTF(("error %d", error)); | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~ /storage/freebsd/src/current/sys/dev/hid/hid.h:212:34: note: expanded fro= m macro 'DPRINTF' 212 | #define DPRINTF(...) DPRINTFN(1, __VA_ARGS__) | ~~~~~~~~~~~~^~~~~~~~~~~~ /storage/freebsd/src/current/sys/dev/hid/hid.h:208:17: note: expanded fro= m macro 'DPRINTFN' 208 | printf("%s: " fmt, \ | ~~~~~~ ^ 1 error generated. --- hkbd.o --- *** [hkbd.o] Error code 1 ----------------------------- --Gordon=20 --IBVGbubFc4T8ux6L Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEYbWI0KY5X7yH/Fy4OQX2V8rP09wFAmipZroACgkQOQX2V8rP 09zNDAgA93aa2y/C3lfrcOjRBRhNVkrIVJUuWmK0aHTXsZO7S8L9b+KlaceJ6DLO Y+/1SbcbsqmxqAV7lRJJ4aZkHCtQO73F2fYULzebJQohoH5Hmgw0RJWXUFCTId36 6Vk4F6OREMOS2fPorlhmZxcrv7fuxZwT4emLtgC+6aZcmnmqgWF/zrs7HGh6fCR7 DW+gPfTrkSCDICduPh2y0z+YEob6SVKQbMQM2YBgXEGq52/NZeZj8DKZGEc8tDjD YB1hFUQt02f43vHCF6UIOBnxtntdXwLHMVsFRHv4T/pQXiI9df4YrAy5OnRBApKN wBnHvMPqEYAcK91hmGI9SktOfYF+gw== =Kl6d -----END PGP SIGNATURE----- --IBVGbubFc4T8ux6L--