Skip site navigation (1)Skip section navigation (2) 
Date:      Fri, 3 Aug 2007 19:10:52 +0800 (KRAST)
From:      Eugene Grosbein <eugen@grosbein.pp.ru>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        krion@FreeBSD.org
Subject:   ports/115166: [patch] misc/asbutton is broken for RELENG_6
Message-ID:  <200708031110.l73BAqfa045958@eg.svzserv.kuzbass.ru>
Resent-Message-ID: <200708031150.l73Bo2PQ009047@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help 

>Number:         115166
>Category:       ports
>Synopsis:       [patch] misc/asbutton is broken for RELENG_6
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 03 11:50:01 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Eugene Grosbein
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
Svyaz Service JSC
>Environment:
System: FreeBSD eg.svzserv.kuzbass.ru 6.2-STABLE FreeBSD 6.2-STABLE #0: Fri Aug 3 14:02:50 KRAST 2007 root@eg.svzserv.kuzbass.ru:/usr/local/obj/usr/local/src/sys/EG i386

>Description:
	Latest commit to ports/misc/asbbutton broke it for RELENG_6

>How-To-Repeat:
	asbutton breaks with SIGSEGV while parsing config file
	due to error in files/patch-asbutton.c

>Fix:

diff -urN asbutton.orig/files/patch-asbutton.c asbutton/files/patch-asbutton.c
--- asbutton.orig/files/patch-asbutton.c	2007-05-27 04:39:02.000000000 +0800
+++ asbutton/files/patch-asbutton.c	2007-08-03 19:06:51.000000000 +0800
@@ -1,14 +1,11 @@
-
-$FreeBSD: ports/misc/asbutton/files/patch-asbutton.c,v 1.1 2007/05/26 20:39:02 krion Exp $
-
---- asbutton.c.orig
-+++ asbutton.c
+--- asbutton.c.orig	1999-07-17 05:59:20.000000000 +0800
++++ asbutton.c	2007-08-03 18:13:09.000000000 +0800
 @@ -605,7 +605,7 @@
  				continue;
  	  		}
  	    	if ( !strncasecmp(line, "button", 6))
 -				if (atoi(&(char)line[6]) == position) 
-+				if (atoi((char)line[6]) == position) 
++				if (atoi(line+6) == position) 
  					break;
  		}
  	} while (1);



Eugene Grosbein
>Release-Note:
>Audit-Trail:
>Unformatted:

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200708031110.l73BAqfa045958>