From owner-svn-src-projects@FreeBSD.ORG Mon Feb 2 18:30:15 2009 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E3AA3106566B; Mon, 2 Feb 2009 18:30:15 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id D1EE08FC23; Mon, 2 Feb 2009 18:30:15 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n12IUFX2004117; Mon, 2 Feb 2009 18:30:15 GMT (envelope-from sam@svn.freebsd.org) Received: (from sam@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n12IUFGd004116; Mon, 2 Feb 2009 18:30:15 GMT (envelope-from sam@svn.freebsd.org) Message-Id: <200902021830.n12IUFGd004116@svn.freebsd.org> From: Sam Leffler Date: Mon, 2 Feb 2009 18:30:15 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org X-SVN-Group: projects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r188015 - projects/cambria/sys/dev/cfi X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Feb 2009 18:30:16 -0000 Author: sam Date: Mon Feb 2 18:30:15 2009 New Revision: 188015 URL: http://svn.freebsd.org/changeset/base/188015 Log: allow bus shims to force the interface width; probing can be problematic with the current design Modified: projects/cambria/sys/dev/cfi/cfi_core.c Modified: projects/cambria/sys/dev/cfi/cfi_core.c ============================================================================== --- projects/cambria/sys/dev/cfi/cfi_core.c Mon Feb 2 18:10:51 2009 (r188014) +++ projects/cambria/sys/dev/cfi/cfi_core.c Mon Feb 2 18:30:15 2009 (r188015) @@ -150,11 +150,16 @@ cfi_probe(device_t dev) sc->sc_tag = rman_get_bustag(sc->sc_res); sc->sc_handle = rman_get_bushandle(sc->sc_res); - sc->sc_width = 1; - while (sc->sc_width <= 4) { - if (cfi_read_qry(sc, CFI_QRY_IDENT) == 'Q') - break; - sc->sc_width <<= 1; + if (sc->sc_width == 0) { + sc->sc_width = 1; + while (sc->sc_width <= 4) { + if (cfi_read_qry(sc, CFI_QRY_IDENT) == 'Q') + break; + sc->sc_width <<= 1; + } + } else if (cfi_read_qry(sc, CFI_QRY_IDENT) != 'Q') { + error = ENXIO; + goto out; } if (sc->sc_width > 4) { error = ENXIO;