From owner-svn-src-head@FreeBSD.ORG  Mon Sep  3 09:05:14 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 545411065673;
	Mon,  3 Sep 2012 09:05:14 +0000 (UTC)
	(envelope-from yanegomi@gmail.com)
Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com
	[209.85.160.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 1120F8FC16;
	Mon,  3 Sep 2012 09:05:13 +0000 (UTC)
Received: by pbbrp2 with SMTP id rp2so7690202pbb.13
	for <multiple recipients>; Mon, 03 Sep 2012 02:05:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=subject:mime-version:content-type:from:in-reply-to:date:cc
	:content-transfer-encoding:message-id:references:to:x-mailer;
	bh=3cSlDRen1/L+5dF+Ed2uRAci+Rz5/7ZWHYXBjSO0KSI=;
	b=SP0JpPA9upyRNft3GHp+2BDqqdjT/ZjNLlI8RuyRCvonqqmXJHnNHj+rhxzpJZZFbR
	vfevFjJZCNnRuWUzCvsxnU+Ibnn2U76ezVgTwlzJLSingGZhUvgsATJFoqmyKi/wFyGs
	HRQSzTTa4kz/9WH652pXT1iDk+YqmDDIPpQIMy0y2s4Bvl/+bvUuR87ZRt4B5/6qzlg8
	uo2EgziNlqvO3tbRlL8RSwUPbGUI35ol+GoaTFu73wUFyYh/QvQZ9PwaJh1kBmt1DFfd
	xUMk+aYwLIHJG5JVg0xXIJn64TRygkvNOKCKd4bnf/B/7AUxvBpG1RxvYXCJFrK2IYPG
	vKpw==
Received: by 10.66.74.3 with SMTP id p3mr32539115pav.49.1346663113455;
	Mon, 03 Sep 2012 02:05:13 -0700 (PDT)
Received: from fuji-wireless.local (c-24-19-191-56.hsd1.wa.comcast.net.
	[24.19.191.56])
	by mx.google.com with ESMTPS id gf8sm9505941pbc.52.2012.09.03.02.05.11
	(version=TLSv1/SSLv3 cipher=OTHER);
	Mon, 03 Sep 2012 02:05:12 -0700 (PDT)
Mime-Version: 1.0 (Apple Message framework v1278)
Content-Type: text/plain; charset=us-ascii
From: Garrett Cooper <yanegomi@gmail.com>
In-Reply-To: <201209030852.q838q6lC053405@svn.freebsd.org>
Date: Mon, 3 Sep 2012 02:05:15 -0700
Content-Transfer-Encoding: 7bit
Message-Id: <A8FC4639-8B1E-4858-A5E8-33D5A4CBA7CF@gmail.com>
References: <201209030852.q838q6lC053405@svn.freebsd.org>
To: Aleksandr Rybalko <ray@FreeBSD.org>
X-Mailer: Apple Mail (2.1278)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r240067 - head/sys/kern
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Sep 2012 09:05:14 -0000

On Sep 3, 2012, at 1:52 AM, Aleksandr Rybalko wrote:

> Author: ray
> Date: Mon Sep  3 08:52:05 2012
> New Revision: 240067
> URL: http://svn.freebsd.org/changeset/base/240067
> 
> Log:
>  Add kern.hintmode sysctl variable to show current state of hints:
>  0 - loader hints in environment only;
>  1 - static hints only
>  2 - fallback mode (Dynamic KENV with fallback to kernel environment)
>  Add kern.hintmode write handler, accept only value 2. That will switch
>  static KENV to dynamic. So it will be possible to change device hints.

...

> +	/* Migrate from static to dynamic hints */
> +	switch (hintmode) {
> +	case 0:
> +		if (dynamic_kenv)
> +			/* Already here */
> +			hintmode = value; /* XXX: Need we switch or not ? */
> +			return (0);

^^^^ typo (missing braces)? ^^^^

Also, don't you need extra glue for jails?

-Garrett