Date: Fri, 15 Mar 2002 11:32:28 -0800 (PST) From: Julian Elischer <julian@elischer.org> To: Dag-Erling Smorgrav <des@ofug.org> Cc: obrien@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_softdep.c Message-ID: <Pine.BSF.4.21.0203151131310.81090-100000@InterJet.elischer.org> In-Reply-To: <xzppu25puf7.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15 Mar 2002, Dag-Erling Smorgrav wrote: > "David O'Brien" <obrien@FreeBSD.org> writes: > > error = 0; > > > > at the beginning of the function is obfuscatation?? > > Hey, I'm not attacking your patch; I was aware of the problem and > considered committing the exact same patch myself. I'm just annoyed > that gcc isn't able to determine that the loop always runs at least > once. But maybe I'm wishing for the moon... Anyway, I was bitching > at gcc, not at you. Sorry if that wasn't clear. So change the loop to be a 'do-while' loop and it will know.. (it probably should be one anyhow if it always runs once..) > > > At the companies > > I've worked at, local variables were _required_ to be initialized after > > their definition. > > Most of the time, this is a good idea, but sometimes it can hide real > errors; like forgetting to set error before returning when an error > actually occurs, so the caller thinks you succeeded. > > DES > -- > Dag-Erling Smorgrav - des@ofug.org > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0203151131310.81090-100000>