From nobody Sat Sep 20 23:14:07 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cTlZ319yLz68XZs for ; Sat, 20 Sep 2025 23:14:19 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cTlZ263Ccz3dHq for ; Sat, 20 Sep 2025 23:14:18 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758410058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xy48y/QgIbQ5c5uwnuAKuTaF9Ou0/NE1iUHDY3lLUQs=; b=aNko+w7uwPm7jkjmWKMgiA2WwEFsocxSQQnsd3Cd8JimbrxDN7COEWbblLDQeRWkBWRhRA vPp3YF2yRVm+Jj4KfFAnLuGLQ2AvTU1GxPkKAwlFkvsc7kkHoNGiCIQfBREQd12a3uEQm1 SbuPBAVVNwjgb0vCfdNsSpXm2l5jTbz5/KxAg90wS8Ak7xVBEWmW7lHTSpYxFJuVfFZaSY JHzDJVGvU3IUrw8UKcs7gTcWUtw8W5qK704EYWMHSojMu2y4wOCVhlC8+eTQofzraea2h2 PIuZNQjSdXH8t5B4OmJfrAlBc+kdw8JHLzdR8J+cZKOgmxrr4KKWvvBHz3Q4Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758410058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xy48y/QgIbQ5c5uwnuAKuTaF9Ou0/NE1iUHDY3lLUQs=; b=R14mBSOIAttaNNHkfWrNXxC3sZVAPOqGG0W05pc+eZPkjlyd1LAjsroJGNgtH3fEzD1fVh nV0Parr8lZMhaM5ZVD9eKn+dCDIAVCZrR3BIuTkH/dVKXsd4JODlq7BrsCEbn0amoT1X1J ziYr1HxlP6WPc/ZrXOhOKFwe42BfzcLpgBKieSYNpllAijL/YomTwEQeEK/0dI0t39ikBB lX9jAw+DhNtjrRbTqyl32j5TUVInHqrgm5EsiNsXENtGlBJr6w8PoUWhWNjFiV9v6meZmH mUNUvV3LiX+TsKHBDzH0dvmYmjpv8TH35lcNGeGZDwAZaIwRGMy/jqE8pf52OA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758410058; a=rsa-sha256; cv=none; b=Tn4C6lwDLJPWgct9MRkx/FaK2zMXCY5M7FAl3sBC/xgPAs+ozZ2iAt8Qvh96srKjcGB7D2 8jvVjc07U8QWf1jQtxi1l9ORmsKvvtgBXdLgXD0Qdp5y8CmJnjxsoU9/6s7f+LxkeTePM7 DRQgqq0oQPANrOqCCZvWqfq7JoEAjJoZ7QPAF0nmUR6mIqffDzpeLYMMJGepSIiYRcKB9r h9kY5e+RqJ2DTnPApuktvFl03sYjr1nTQp6pX/GB+DZnrjHiM8UT5pxYLZCyOgVNblFtZv REL4YMw0EOW+At/wr57CxlWVAHnJd3Aro9wXf6U2nv9suUZTC+mdeljeWsJt6w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cTlZ25Gk4z11qb for ; Sat, 20 Sep 2025 23:14:18 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-4b7a69fb918so3676371cf.1 for ; Sat, 20 Sep 2025 16:14:18 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUoU5SjyGj5Q8UTepalC1oumotY0YvxYb4GTKSf97dzBDYQO/fp7oGgKhKtTyG2Qtt4jftOsrHCp+9I+hR6zK9VRx3ISQ==@freebsd.org X-Gm-Message-State: AOJu0YzY9/owCsS3YPZZ6FmoARyBzZrHo2XSa7VxYWmecGIbQ/Sh+rx4 CYNBCm9i7aBop7S2JXzgAvkogJyMh7sCNMucVw4ktWUkGbl1ZP8Hvuo8264zoreVCE52QNF6pkZ SKRgKdVbMu414HlJkn88hrO4/3mW8mD4= X-Google-Smtp-Source: AGHT+IFqQ0iSz++mtwGQd2X3SggHCMbkWoKEq80mJ17ExzlcS/KSjXVC5xwQmmzwJ0pTgspDDH9mzMEnz3+H2mNgzkU= X-Received: by 2002:a05:620a:19a7:b0:80e:455:940d with SMTP id af79cd13be357-83ba438b262mr654825785a.5.1758410058221; Sat, 20 Sep 2025 16:14:18 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202509191603.58JG3EF6037438@gitrepo.freebsd.org> In-Reply-To: From: Nuno Teixeira Date: Sun, 21 Sep 2025 00:14:07 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: AS18NWDLzkmpW97Q2ySBxgXE7yKyFRvkqbgsJXul9_FTk1OsH_fKG5MKFteiPPk Message-ID: Subject: Re: git: 87a7b35f04b6 - main - bsdinstall: fix vfs.zfs.vdev.min_auto_ashift oid To: Ed Maste Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000e3ce8f063f43be31" --000000000000e3ce8f063f43be31 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable (...) Maybe this need to be fixed somehow because values are different: % sysctl -a | grep ashift <118>sysctl: unknown oid 'vfs.zfs.min_auto_ashift' at line 9 <118>sysctl: unknown oid 'vfs.zfs.min_auto_ashift' at line 9 <118>sysctl: unknown oid 'vfs.zfs.min_auto_ashift' at line 9 <118>sysctl: unknown oid 'vfs.zfs.min_auto_ashift' at line 9 <118>sysctl: unknown oid 'vfs.zfs.min_auto_ashift' at line 9 vfs.zfs.vdev.max_auto_ashift: 14 vfs.zfs.vdev.min_auto_ashift: 9 vfs.zfs.vdev.file.physical_ashift: 9 vfs.zfs.vdev.file.logical_ashift: 9 Nuno Teixeira escreveu (s=C3=A1bado, 20/09/2025 =C3= =A0(s) 23:41): > Hello! > > I've just upgraded to a recent main and on boot i see: > > `sysctl: unknown oid 'vfs.zfs.min_auto_ashift' at line 9` > > I remember this line in /etc/sysctl.conf for years: > > ``` > # > # This file is read when going to multi-user and its contents piped thru > # ``sysctl'' to adjust kernel values. ``man 5 sysctl.conf'' for details= . > # > > # Uncomment this to prevent users from seeing information about processes > that > # are being run under another UID. > #security.bsd.see_other_uids=3D0 > vfs.zfs.min_auto_ashift=3D12 > ``` > Do we need to fix it from vfs.zfs.min_auto_ashift -> vfs.zfs.vdev.min_aut= o_ashift > on /etc/sysctl.conf? > > Cheers, > > Ed Maste escreveu (sexta, 19/09/2025 =C3=A0(s) 17:03= ): > >> The branch main has been updated by emaste: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=3D87a7b35f04b60956e9aa192680ae80= 773ec38f14 >> >> commit 87a7b35f04b60956e9aa192680ae80773ec38f14 >> Author: Siva Mahadevan >> AuthorDate: 2025-07-15 16:45:24 +0000 >> Commit: Ed Maste >> CommitDate: 2025-09-19 16:02:57 +0000 >> >> bsdinstall: fix vfs.zfs.vdev.min_auto_ashift oid >> >> Signed-off-by: Siva Mahadevan >> PR: 266374 >> Pull request: https://github.com/freebsd/freebsd-src/pull/1851 >> Reviewed by: emaste >> Sponsored by: The FreeBSD Foundation >> --- >> usr.sbin/bsdinstall/scripts/zfsboot | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/usr.sbin/bsdinstall/scripts/zfsboot >> b/usr.sbin/bsdinstall/scripts/zfsboot >> index aa05faa7d3dd..5fbf56ea59ac 100755 >> --- a/usr.sbin/bsdinstall/scripts/zfsboot >> +++ b/usr.sbin/bsdinstall/scripts/zfsboot >> @@ -69,7 +69,7 @@ f_include $BSDCFG_SHARE/variable.subr >> : ${ZFSBOOT_VDEV_TYPE:=3Dstripe} >> >> # >> -# Should we use sysctl(8) vfs.zfs.min_auto_ashift=3D12 to force 4K sect= ors? >> +# Should we use sysctl(8) vfs.zfs.vdev.min_auto_ashift=3D12 to force 4K >> sectors? >> # >> : ${ZFSBOOT_FORCE_4K_SECTORS=3D1} >> >> @@ -221,7 +221,7 @@ PRINTF_CONF=3D"printf '%s=3D\"%%s\"\\\n' %s >> \"%s\= "" >> PRINTF_FSTAB=3D'printf "$FSTAB_FMT" "%s" "%s" "%s" "%s" "%s" "%s" >> "%= s"' >> SHELL_TRUNCATE=3D':> "%s"' >> SWAP_GMIRROR_LABEL=3D'gmirror label swap %s' >> -SYSCTL_ZFS_MIN_ASHIFT_12=3D'sysctl vfs.zfs.min_auto_ashift=3D12' >> +SYSCTL_ZFS_MIN_ASHIFT_12=3D'sysctl vfs.zfs.vdev.min_auto_ashift=3D12' >> UMOUNT=3D'umount "%s"' >> ZFS_CREATE_WITH_OPTIONS=3D'zfs create %s "%s"' >> ZFS_MOUNT=3D'zfs mount "%s"' >> @@ -255,7 +255,7 @@ msg_encrypt_disks=3D"Encrypt Disks?" >> msg_encrypt_disks_help=3D"Use geli(8) to encrypt all data partitions" >> msg_error=3D"Error" >> msg_force_4k_sectors=3D"Force 4K Sectors?" >> -msg_force_4k_sectors_help=3D"Align partitions to 4K sector boundries an= d >> set vfs.zfs.min_auto_ashift=3D12" >> +msg_force_4k_sectors_help=3D"Align partitions to 4K sector boundries an= d >> set vfs.zfs.vdev.min_auto_ashift=3D12" >> msg_freebsd_installer=3D"$OSNAME Installer" >> msg_geli_password=3D"Enter a strong passphrase, used to protect your >> encryption keys. You will be required to enter this passphrase each time >> the system is booted" >> msg_geli_setup=3D"Initializing encryption on selected disks,\n this wil= l >> take several seconds per disk" >> @@ -1099,7 +1099,7 @@ zfs_create_boot() >> # >> f_dprintf "$funcname: Preparing disk partitions for ZFS pool..." >> >> - # Force 4K sectors using vfs.zfs.min_auto_ashift=3D12 >> + # Force 4K sectors using vfs.zfs.vdev.min_auto_ashift=3D12 >> if [ "$ZFSBOOT_FORCE_4K_SECTORS" ]; then >> f_dprintf "$funcname: With 4K sectors..." >> f_eval_catch $funcname sysctl "$SYSCTL_ZFS_MIN_ASHIFT_12= " >> \ >> @@ -1382,7 +1382,7 @@ zfs_create_boot() >> >> if [ "$ZFSBOOT_FORCE_4K_SECTORS" ]; then >> f_eval_catch $funcname echo "$ECHO_APPEND" \ >> - 'vfs.zfs.min_auto_ashift=3D12' \ >> + 'vfs.zfs.vdev.min_auto_ashift=3D12' \ >> $BSDINSTALL_TMPETC/sysctl.conf.zfs || return $FAILU= RE >> fi >> >> >> > > -- > Nuno Teixeira > FreeBSD UNIX: Web: https://FreeBSD.org > --=20 Nuno Teixeira FreeBSD UNIX: Web: https://FreeBSD.org --000000000000e3ce8f063f43be31 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
(...)

Maybe this need to be fixed someho= w because values are different:

% sysctl -a | grep ashift
<118= >sysctl: unknown oid 'vfs.zfs.min_auto_ashift' at line 9
<= 118>sysctl: unknown oid 'vfs.zfs.min_auto_ashift' at line 9
&= lt;118>sysctl: unknown oid 'vfs.zfs.min_auto_ashift' at line 9<118>sysctl: unknown oid 'vfs.zfs.min_auto_ashift' at line = 9
<118>sysctl: unknown oid 'vfs.zfs.min_auto_ashift' at li= ne 9
vfs.zfs.vdev.max_auto_ashift: 14
vfs.zfs.vdev.min_auto_ashift: 9=
vfs.zfs.vdev.file.physical_ashift: 9
vfs.zfs.vdev.file.logical_ashif= t: 9

Nuno Teixeira <eduardo@freebsd.org> escreveu (s=C3=A1bado, 20/09/2025 =C3= =A0(s) 23:41):
<= div dir=3D"ltr">
Hello!

I've just upgraded= to a recent main and on boot i see:

`sysctl: unknown oid 'vfs.z= fs.min_auto_ashift' at line 9`

I remember this line i= n /etc/sysctl.conf for years:

```
#
# =C2=A0This file i= s read when going to multi-user and its contents piped thru
# =C2=A0``sy= sctl'' to adjust kernel values. =C2=A0``man 5 sysctl.conf''= for details.
#

# Uncomment this to prevent users from seeing inf= ormation about processes that
# are being run under another UID.
#sec= urity.bsd.see_other_uids=3D0
vfs.zfs.min_auto_ashift=3D12
```
Do we need to fix it from=C2=A0vfs.zfs.= min_auto_ashift ->=C2=A0vfs.zfs.vdev.min_a= uto_ashift on /etc/sysctl.conf?

Cheers,

Ed Maste <emaste@freebsd.org> escreveu (sexta, 19/09/2025 =C3=A0(s= ) 17:03):
The br= anch main has been updated by emaste:

URL: https://cgit.= FreeBSD.org/src/commit/?id=3D87a7b35f04b60956e9aa192680ae80773ec38f14
commit 87a7b35f04b60956e9aa192680ae80773ec38f14
Author:=C2=A0 =C2=A0 =C2=A0Siva Mahadevan <me@svmhdvn.name>
AuthorDate: 2025-07-15 16:45:24 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Ed Maste <emaste@FreeBSD.org>
CommitDate: 2025-09-19 16:02:57 +0000

=C2=A0 =C2=A0 bsdinstall: fix vfs.zfs.vdev.min_auto_ashift oid

=C2=A0 =C2=A0 Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
=C2=A0 =C2=A0 PR: 266374
=C2=A0 =C2=A0 Pull request: https://github.com/freeb= sd/freebsd-src/pull/1851
=C2=A0 =C2=A0 Reviewed by: emaste
=C2=A0 =C2=A0 Sponsored by: The FreeBSD Foundation
---
=C2=A0usr.sbin/bsdinstall/scripts/zfsboot | 10 +++++-----
=C2=A01 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/usr.sbin/bsdinstall/scripts/zfsboot b/usr.sbin/bsdinstall/scri= pts/zfsboot
index aa05faa7d3dd..5fbf56ea59ac 100755
--- a/usr.sbin/bsdinstall/scripts/zfsboot
+++ b/usr.sbin/bsdinstall/scripts/zfsboot
@@ -69,7 +69,7 @@ f_include $BSDCFG_SHARE/variable.subr
=C2=A0: ${ZFSBOOT_VDEV_TYPE:=3Dstripe}

=C2=A0#
-# Should we use sysctl(8) vfs.zfs.min_auto_ashift=3D12 to force 4K sectors= ?
+# Should we use sysctl(8) vfs.zfs.vdev.min_auto_ashift=3D12 to force 4K se= ctors?
=C2=A0#
=C2=A0: ${ZFSBOOT_FORCE_4K_SECTORS=3D1}

@@ -221,7 +221,7 @@ PRINTF_CONF=3D"printf '%s=3D\"%%s\"\= \\n' %s >> \"%s\""
=C2=A0PRINTF_FSTAB=3D'printf "$FSTAB_FMT" "%s" &quo= t;%s" "%s" "%s" "%s" "%s" >= > "%s"'
=C2=A0SHELL_TRUNCATE=3D':> "%s"'
=C2=A0SWAP_GMIRROR_LABEL=3D'gmirror label swap %s'
-SYSCTL_ZFS_MIN_ASHIFT_12=3D'sysctl vfs.zfs.min_auto_ashift=3D12' +SYSCTL_ZFS_MIN_ASHIFT_12=3D'sysctl vfs.zfs.vdev.min_auto_ashift=3D12&#= 39;
=C2=A0UMOUNT=3D'umount "%s"'
=C2=A0ZFS_CREATE_WITH_OPTIONS=3D'zfs create %s "%s"'
=C2=A0ZFS_MOUNT=3D'zfs mount "%s"'
@@ -255,7 +255,7 @@ msg_encrypt_disks=3D"Encrypt Disks?"
=C2=A0msg_encrypt_disks_help=3D"Use geli(8) to encrypt all data partit= ions"
=C2=A0msg_error=3D"Error"
=C2=A0msg_force_4k_sectors=3D"Force 4K Sectors?"
-msg_force_4k_sectors_help=3D"Align partitions to 4K sector boundries = and set vfs.zfs.min_auto_ashift=3D12"
+msg_force_4k_sectors_help=3D"Align partitions to 4K sector boundries = and set vfs.zfs.vdev.min_auto_ashift=3D12"
=C2=A0msg_freebsd_installer=3D"$OSNAME Installer"
=C2=A0msg_geli_password=3D"Enter a strong passphrase, used to protect = your encryption keys. You will be required to enter this passphrase each ti= me the system is booted"
=C2=A0msg_geli_setup=3D"Initializing encryption on selected disks,\n t= his will take several seconds per disk"
@@ -1099,7 +1099,7 @@ zfs_create_boot()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 #
=C2=A0 =C2=A0 =C2=A0 =C2=A0 f_dprintf "$funcname: Preparing disk parti= tions for ZFS pool..."

-=C2=A0 =C2=A0 =C2=A0 =C2=A0# Force 4K sectors using vfs.zfs.min_auto_ashif= t=3D12
+=C2=A0 =C2=A0 =C2=A0 =C2=A0# Force 4K sectors using vfs.zfs.vdev.min_auto_= ashift=3D12
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if [ "$ZFSBOOT_FORCE_4K_SECTORS" ]; t= hen
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 f_dprintf "$fu= ncname: With 4K sectors..."
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 f_eval_catch $funcn= ame sysctl "$SYSCTL_ZFS_MIN_ASHIFT_12" \
@@ -1382,7 +1382,7 @@ zfs_create_boot()

=C2=A0 =C2=A0 =C2=A0 =C2=A0 if [ "$ZFSBOOT_FORCE_4K_SECTORS" ]; t= hen
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 f_eval_catch $funcn= ame echo "$ECHO_APPEND" \
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '= ;vfs.zfs.min_auto_ashift=3D12' \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '= ;vfs.zfs.vdev.min_auto_ashift=3D12' \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0$BSDINSTALL_TMPETC/sysctl.conf.zfs || return $FAILURE
=C2=A0 =C2=A0 =C2=A0 =C2=A0 fi




--
Nuno Teixeira
=
FreeBSD UNIX:=C2=A0 <eduardo@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 https://Fr= eeBSD.org


--
Nuno Teixeira
=
FreeBSD UNIX:=C2=A0 <eduardo@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 https://Fr= eeBSD.org
--000000000000e3ce8f063f43be31--