From owner-svn-src-all@FreeBSD.ORG  Thu Sep 18 22:34:53 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 85F7F9F1;
 Thu, 18 Sep 2014 22:34:53 +0000 (UTC)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 716A8EAE;
 Thu, 18 Sep 2014 22:34:53 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.9/8.14.9) with ESMTP id s8IMYrVC007967;
 Thu, 18 Sep 2014 22:34:53 GMT (envelope-from pjd@FreeBSD.org)
Received: (from pjd@localhost)
 by svn.freebsd.org (8.14.9/8.14.9/Submit) id s8IMYr75007966;
 Thu, 18 Sep 2014 22:34:53 GMT (envelope-from pjd@FreeBSD.org)
Message-Id: <201409182234.s8IMYr75007966@svn.freebsd.org>
X-Authentication-Warning: svn.freebsd.org: pjd set sender to pjd@FreeBSD.org
 using -f
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
Date: Thu, 18 Sep 2014 22:34:53 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r271847 - head/lib/libnv
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Sep 2014 22:34:53 -0000

Author: pjd
Date: Thu Sep 18 22:34:52 2014
New Revision: 271847
URL: http://svnweb.freebsd.org/changeset/base/271847

Log:
  Don't use nvl in case of a failure.
  
  Reported by:	Coverity
  CID:		1238922

Modified:
  head/lib/libnv/nvpair.c

Modified: head/lib/libnv/nvpair.c
==============================================================================
--- head/lib/libnv/nvpair.c	Thu Sep 18 22:27:02 2014	(r271846)
+++ head/lib/libnv/nvpair.c	Thu Sep 18 22:34:52 2014	(r271847)
@@ -963,7 +963,8 @@ nvpair_createv_nvlist(const nvlist_t *va
 	    namefmt, nameap);
 	if (nvp == NULL)
 		nvlist_destroy(nvl);
-	nvlist_set_parent(nvl, nvp);
+	else
+		nvlist_set_parent(nvl, nvp);
 
 	return (nvp);
 }