Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 18 Sep 2014 22:34:53 +0000 (UTC)
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r271847 - head/lib/libnv
Message-ID:  <201409182234.s8IMYr75007966@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: pjd
Date: Thu Sep 18 22:34:52 2014
New Revision: 271847
URL: http://svnweb.freebsd.org/changeset/base/271847

Log:
  Don't use nvl in case of a failure.
  
  Reported by:	Coverity
  CID:		1238922

Modified:
  head/lib/libnv/nvpair.c

Modified: head/lib/libnv/nvpair.c
==============================================================================
--- head/lib/libnv/nvpair.c	Thu Sep 18 22:27:02 2014	(r271846)
+++ head/lib/libnv/nvpair.c	Thu Sep 18 22:34:52 2014	(r271847)
@@ -963,7 +963,8 @@ nvpair_createv_nvlist(const nvlist_t *va
 	    namefmt, nameap);
 	if (nvp == NULL)
 		nvlist_destroy(nvl);
-	nvlist_set_parent(nvl, nvp);
+	else
+		nvlist_set_parent(nvl, nvp);
 
 	return (nvp);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201409182234.s8IMYr75007966>