From owner-svn-src-all@FreeBSD.ORG Sat Aug 3 16:25:22 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 2FF797C6; Sat, 3 Aug 2013 16:25:22 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9BD9726F3; Sat, 3 Aug 2013 16:25:21 +0000 (UTC) Received: from alph.d.allbsd.org (p2049-ipbf1102funabasi.chiba.ocn.ne.jp [122.26.101.49]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id r73GP1N5025618 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 4 Aug 2013 01:25:11 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [IPv6:::1]) (authenticated bits=0) by alph.d.allbsd.org (8.14.5/8.14.5) with ESMTP id r73GOxfH089347; Sun, 4 Aug 2013 01:25:01 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Sun, 04 Aug 2013 01:24:45 +0900 (JST) Message-Id: <20130804.012445.1330578101731029775.hrs@allbsd.org> To: pjd@FreeBSD.org Subject: Re: svn commit: r252603 - head/usr.sbin/rwhod From: Hiroki Sato In-Reply-To: <201307032104.r63L4KEE015937@svn.freebsd.org> References: <201307032104.r63L4KEE015937@svn.freebsd.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Sun_Aug__4_01_24_45_2013_098)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Sun, 04 Aug 2013 01:25:11 +0900 (JST) X-Spam-Status: No, score=-90.6 required=13.0 tests=CONTENT_TYPE_PRESENT, DIRECTOCNDYN,DYN_PBL,RCVD_IN_PBL,SPF_SOFTFAIL,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Aug 2013 16:25:22 -0000 ----Security_Multipart(Sun_Aug__4_01_24_45_2013_098)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Pawel Jakub Dawidek wrote in <201307032104.r63L4KEE015937@svn.freebsd.org>: pj> Author: pjd pj> Date: Wed Jul 3 21:04:20 2013 pj> New Revision: 252603 pj> URL: http://svnweb.freebsd.org/changeset/base/252603 pj> pj> Log: pj> The whole sending functionality was implemented within signal handler, pj> which is very bad idea. Split sending and receiving in two processes, pj> which fixes this problem and will help to sandbox rwhod. pj> pj> Submitted by: Mariusz Zaborski pj> Sponsored by: Google Summer of Code 2013 pj> Reviewed by: pjd pj> MFC after: 1 month (snip) pj> if (!quiet_mode) { pj> - signal(SIGALRM, onalrm); pj> - onalrm(0); pj> + pid_child_receiver = pdfork(&fdp, 0); pj> + if (pid_child_receiver == 0) { pj> + receiver_process(); pj> + } else if (pid_child_receiver > 0) { pj> + sender_process(); pj> + } else if (pid_child_receiver == -1) { pj> + syslog(LOG_ERR, "pdfork: %m"); pj> + exit(1); pj> + } pdfork() is available only when options PROCDESC is defined and GENERIC does not have it. -- Hiroki ----Security_Multipart(Sun_Aug__4_01_24_45_2013_098)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (FreeBSD) iEYEABECAAYFAlH9Ls0ACgkQTyzT2CeTzy3zhQCgyqLDaLEevKuT+U4a7LLsubl1 GXIAn1hB/cOIFW8nx3+dvEKH5Ppj6zc0 =0G45 -----END PGP SIGNATURE----- ----Security_Multipart(Sun_Aug__4_01_24_45_2013_098)----