From owner-svn-ports-all@FreeBSD.ORG  Fri Aug 10 04:55:41 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id 3C4711065673;
	Fri, 10 Aug 2012 04:55:41 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from [127.0.0.1] (hub.freebsd.org [IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id 1BD7C14E1A6;
	Fri, 10 Aug 2012 04:55:38 +0000 (UTC)
Message-ID: <5024944A.9020603@FreeBSD.org>
Date: Thu, 09 Aug 2012 21:55:38 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:14.0) Gecko/20120714 Thunderbird/14.0
MIME-Version: 1.0
To: Olivier Duchateau <olivierd@FreeBSD.org>
References: <201208091937.q79JbxJa045133@svn.freebsd.org>
In-Reply-To: <201208091937.q79JbxJa045133@svn.freebsd.org>
X-Enigmail-Version: 1.4.3
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, rene@FreeBSD.org, svn-ports-all@freebsd.org,
	miwi@FreeBSD.org, ports-committers@freebsd.org
Subject: Re: svn commit: r302353 - head/x11-wm/xfce4-panel
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
	<mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
	<mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Aug 2012 04:55:41 -0000

On 08/09/2012 12:37 PM, Olivier Duchateau wrote:
>  
> +.if empty(PORT_OPTIONS:MNLS)
> +	@${REINPLACE_CMD} -e 's|	icons \\|	icons| ; \
> +		s|	po||' ${WRKSRC}/Makefile.in
> +.endif

This is badly broken on several levels. Clearly it wasn't tested, which
is disappointing. But the pointy hats go to miwi and rene who clearly
did not review this carefully.

Olivier, I tested r302375 and it does what it seems like you intended to
do here. Please confirm.

Doug