From owner-svn-src-stable@freebsd.org Thu Mar 29 19:49:20 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9A6E8F713CA for ; Thu, 29 Mar 2018 19:49:20 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x229.google.com (mail-it0-x229.google.com [IPv6:2607:f8b0:4001:c0b::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DB01D80B1C for ; Thu, 29 Mar 2018 19:49:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x229.google.com with SMTP id 71-v6so7284758ith.2 for ; Thu, 29 Mar 2018 12:49:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=NJUaloFldYjLbCdkU8lzGgypCZpbX6zLiBPrkfMNaUk=; b=Sdgwkvof7aIzKzVArmhbZjwDp1nE4eQNuf2S7mhZFv83ivFGzCn8Mrmdjgqe5kq1yS QR0V5/1yQsBVqaqBBSnAZasLDqqiIN4j3gfVK+KQ9fHTJQBFNqqm/ydIR9ikxxJNFBUF M7WOMhmOVymcS1wDeRIr+Dm08JGYMvcKEuHP+XV24Jjr8swYFj93rU78n08b8gz2U2nx sea105YDR6ygOTeMaXZh/e55g5/wxkm9l/DkOF+BgcO8u/PPPBCTbOqI6O37OV+BcF4S PAP9rjYxctp3kbTX+0Mx3ftg1cpXVm10m7wQ06Es/4NIgUjf8mrD8mNDxAGGNHEb5qm4 4fvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=NJUaloFldYjLbCdkU8lzGgypCZpbX6zLiBPrkfMNaUk=; b=XayKzF26VlNUWSpCEI1O0PyRlL9u+2vwqeU5fOGRzBegueUB0q70Z/xir6utdskMhy vO2MbukL0lpCESxbOQ+1mgQRfN0YcW+nl0ZaiYywrCKF6Mjab7hV2H0h64z5m3+vcvMr Z1orR6pqT3NJttD6nzGEQeSXpRMDw9xO4poR4WRlNRYCtZbd5Ws32rwuQB7K881gFOsM lcJCus1W9vrl0l2hC8wEDX6YlrwPH6MhMSfTKYcZ2B30UTIP8w67ZE2GRRzT5S4se36E LP0vu1JZjN5h20FJpz6MOpqzyUrgAFo2ahzEFKLBqEt+X2sZ5uOpIbnKEtWTuOJt1vJZ cfVw== X-Gm-Message-State: ALQs6tBzasqczEE32qEBQ04mWbtBILR6BKxAhKP6z+cGl+w88zSqOvIE 0ZwVVV9s1nPEw4pj7YdAQqIOKVagH9InzY4Dh9gy3Q== X-Google-Smtp-Source: AIpwx4+Gx1rAjMOXcEk9BmbdXtBFzySaeIdQsbeKmXl73TCEs452D05cZANrhIJDXuI+KPnQq+ps2j4NBMEXanLRofQ= X-Received: by 2002:a24:fa83:: with SMTP id v125-v6mr360125ith.36.1522352959186; Thu, 29 Mar 2018 12:49:19 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.203.196 with HTTP; Thu, 29 Mar 2018 12:49:18 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <1522352399.49673.120.camel@freebsd.org> References: <201803291633.w2TGXinX064128@pdx.rh.CN85.dnsmgr.net> <1522352399.49673.120.camel@freebsd.org> From: Warner Losh Date: Thu, 29 Mar 2018 13:49:18 -0600 X-Google-Sender-Auth: fL62FwrmsepTnG-XLxbEcpYjwi0 Message-ID: Subject: Re: svn commit: r331728 - in stable/11/etc: . rc.d To: Ian Lepore Cc: "Rodney W. Grimes" , Marcelo Araujo , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 19:49:20 -0000 On Thu, Mar 29, 2018 at 1:39 PM, Ian Lepore wrote: > On Thu, 2018-03-29 at 09:33 -0700, Rodney W. Grimes wrote: > > > > > > On Thu, 2018-03-29 at 06:20 -0700, Rodney W. Grimes wrote: > > > > > > > > > > > > > > > > > > > Author: araujo > > > > > Date: Thu Mar 29 04:51:07 2018 > > > > > New Revision: 331728 > > > > > URL: https://svnweb.freebsd.org/changeset/base/331728 > > > > > > > > > > Log: > > > > > ? MFC r329817: > > > > I must of missed this when it landed in ^/head > > > > > > > > > > > > > > > > > > > ? The firewall_type is ignored if not set in rc.conf or > rc.conf.local, > > > > > ? after r190575 there is an option to call rc.firewall with the > firewall_type > > > > > ? passed in as an argument. > > > > > ?? > > > > > ? Submitted by: David P. Discher > > > > > ? Sponsored by: iXsystems Inc. > > > > > ? Differential Revision: https://reviews.freebsd.org/D14286 > > > > No one accepted it :-(. > > > > > > > That's not a blocker for committing; plenty of time elapsed to allow > > > anyone to reject the change. IMO, even a flat-out rejection isn't a > > > blocker to committing except for things like random or crypto code that > > > require formal approval (but I'd certainly think hard about committing > > > if people rejected the change, and put some effort into finding a > > > compromise first). > > It seems that the Phabricator review system is somewhat disfunctional > > in that actual review is only happening in some cases. Some people > > have even stated they flat out hate it. Others say that it is the > > way to go. > > > > Which is exactly why phab reviews are optional. There are some of us > who've said that if they become mandatory, we're done working on > freebsd. Personally, I put things up for review if I have some doubts > about my choices, or if it's in an area of the system I'm not very > familiar with. If nobody wants to review the changes within a week or > two, I commit and move on. > phab is there to make things better. When there's changes worth reviewing, I use phab. When there's trivial changes or even boring minor ones, there's no benefit from the review. It adds process without adding value, which is lame. Especially for a project that's a volunteer project where people's time may be limited and you need to be as efficient as possible with it. Doing things that add value, sure. Doing things to tick a box, forget it. Warner