From owner-freebsd-current@FreeBSD.ORG Thu Dec 4 15:03:27 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B69D116A4CF for ; Thu, 4 Dec 2003 15:03:27 -0800 (PST) Received: from perrin.nxad.com (internal.nxad.com [69.1.70.251]) by mx1.FreeBSD.org (Postfix) with ESMTP id 59D3B43FEA for ; Thu, 4 Dec 2003 15:03:26 -0800 (PST) (envelope-from sean@nxad.com) Received: by perrin.nxad.com (Postfix, from userid 1001) id 2BEF721063; Thu, 4 Dec 2003 15:02:08 -0800 (PST) Date: Thu, 4 Dec 2003 15:02:08 -0800 From: Sean Chittenden To: Mathew Kanner Message-ID: <20031204230208.GS16547@perrin.nxad.com> References: <20031203060710.GJ54011@cnd.mcgill.ca> <20031203090426.GH16547@perrin.nxad.com> <20031203091401.GA688@perrin.nxad.com> <20031203165719.GL54011@cnd.mcgill.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20031203165719.GL54011@cnd.mcgill.ca> X-PGP-Key: finger seanc@FreeBSD.org X-PGP-Fingerprint: 3849 3760 1AFE 7B17 11A0 83A6 DD99 E31F BC84 B341 X-Web-Homepage: http://sean.chittenden.org/ User-Agent: Mutt/1.5.4i cc: Jesse Guardiani cc: freebsd-current@FreeBSD.org Subject: Re: please test pcm channel patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Dec 2003 23:03:27 -0000 > > > > Hello All, > > > > Please test this PCM patch. It creates seperate locking > > > > classes for PCM channels and should prevent the warning where > > > > multiple mutexes from the same class are held (as reported > > > > recently). I believe this to be a good strategy as it masks fewer > > > > errors. > > > > > > I can confirm that this patch fixes my LOR for pcm(4). -sc > > > > Bah! I got 30min into playing tunes and picked the same LOR up not > > more than 5min after sending this. :( Sorry for the false alarm. > > > > acquiring duplicate lock of same type: "pcm record channel" > > 1st pcm0:record:0 @ /usr/src/sys/dev/sound/pcm/dsp.c:144 > > 2nd pcm0:play:0 @ /usr/src/sys/dev/sound/pcm/dsp.c:146 > > Stack backtrace: > > Sean, > I found the mistake, I assumed that a variable was initialized > when it wasn't. Sorry for asking you to test a stupid patch before. > Please try this one. Haven't had a LOR in the last 24hrs, I think you got a winner here. -sc -- Sean Chittenden