From owner-svn-src-all@FreeBSD.ORG Sun Feb 13 20:05:05 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8249E1065674; Sun, 13 Feb 2011 20:05:05 +0000 (UTC) (envelope-from ivoras@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id 1C5E18FC1B; Sun, 13 Feb 2011 20:05:04 +0000 (UTC) Received: by qwj9 with SMTP id 9so2592547qwj.13 for ; Sun, 13 Feb 2011 12:05:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:from :date:x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=yLzmwc7E34STKgOBznNZaHR5cKSOz1cu2GsjtVdqh7o=; b=eNeJSqv/fITwW9uc9NWrfUovb6QtpERtT55LVk4yjG50GuWAASZwdh0akiEiFURkI4 tz04HhXJteRcpgly336WCNYseTchhCUAslcZq36AIy89MMDFwAWOScf114Pj310Yc+H2 C7h3T4erwJzIFzE40l13ZUauQl4p9KHuLxO2U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=n2wNHf9yID4O1hGYeETupdN9WdjBoUydE2eH3SEaBbZzduINAFKpvo/XxseYTvCoUI OaDv+HEtcSy36wkJnMDBQRBVqjRSn+8i0atoMfokTLHydv331xdZ90Yxe+z4Oej1mJAq BVMMZ/LEPPDvjB9seqBLUvN0KcgPcwVEietaU= Received: by 10.229.95.193 with SMTP id e1mr2167384qcn.171.1297625732346; Sun, 13 Feb 2011 11:35:32 -0800 (PST) MIME-Version: 1.0 Sender: ivoras@gmail.com Received: by 10.229.188.140 with HTTP; Sun, 13 Feb 2011 11:34:52 -0800 (PST) In-Reply-To: <20110213213251.B1474@besplex.bde.org> References: <201102121312.p1CDCjhD002584@svn.freebsd.org> <20110213213251.B1474@besplex.bde.org> From: Ivan Voras Date: Sun, 13 Feb 2011 20:34:52 +0100 X-Google-Sender-Auth: 2uuAzy7PlY78MHc9srSJIS1c1w8 Message-ID: To: Bruce Evans Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Konstantin Belousov Subject: Re: svn commit: r218603 - head/sbin/tunefs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Feb 2011 20:05:05 -0000 On 13 February 2011 11:51, Bruce Evans wrote: > On Sat, 12 Feb 2011, Konstantin Belousov wrote: > >> Log: >> =C2=A0When creating a directory entry for the journal, always read at le= ast >> =C2=A0the fragment, and write the full block. Reading less might not wor= k >> =C2=A0due to device sector size bigger then size of direntries in the >> =C2=A0last directory fragment. > > I think it should always write full fragments too (and the kernel should > always read/write in units of fragments, not sectors of any size). Or at least One Single Variable, preferably recorded in the superblock, so when the need arises there's only one thing to change (so it might as well be fragment size in case of UFS). There is currently nothing technically wrong with what this commit does, but it's pretty much a certainty that future will be more strange than today and future developers may forget there are two places they need to change.