Date: Sun, 13 Feb 2011 20:34:52 +0100 From: Ivan Voras <ivoras@freebsd.org> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Konstantin Belousov <kib@freebsd.org> Subject: Re: svn commit: r218603 - head/sbin/tunefs Message-ID: <AANLkTi=RED0hpX8aaw-icvYPPtc6pPhnuw2bT8-TarLx@mail.gmail.com> In-Reply-To: <20110213213251.B1474@besplex.bde.org> References: <201102121312.p1CDCjhD002584@svn.freebsd.org> <20110213213251.B1474@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13 February 2011 11:51, Bruce Evans <brde@optusnet.com.au> wrote: > On Sat, 12 Feb 2011, Konstantin Belousov wrote: > >> Log: >> =C2=A0When creating a directory entry for the journal, always read at le= ast >> =C2=A0the fragment, and write the full block. Reading less might not wor= k >> =C2=A0due to device sector size bigger then size of direntries in the >> =C2=A0last directory fragment. > > I think it should always write full fragments too (and the kernel should > always read/write in units of fragments, not sectors of any size). Or at least One Single Variable, preferably recorded in the superblock, so when the need arises there's only one thing to change (so it might as well be fragment size in case of UFS). There is currently nothing technically wrong with what this commit does, but it's pretty much a certainty that future will be more strange than today and future developers may forget there are two places they need to change.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTi=RED0hpX8aaw-icvYPPtc6pPhnuw2bT8-TarLx>