From nobody Sun Jan 11 05:34:22 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dpkjF4SmHz6NWR6 for ; Sun, 11 Jan 2026 05:34:41 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dpkjF0Tllz3M3p for ; Sun, 11 Jan 2026 05:34:41 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=CwNEWjVb; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::630 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-2a09d981507so32099745ad.1 for ; Sat, 10 Jan 2026 21:34:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768109675; x=1768714475; darn=freebsd.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=TM21KDyhcJUoAmM+A858DiQ2z1+q97+OMUE6Jv88IaM=; b=CwNEWjVbDOHI4Om4LLkb/tu3jSSMbWvqmmKqvhVoubh4ya2M3u+3R1B6kgAO4Xql97 ZvX88ZkYyhOA57jLtmpTeZySN4nP0ib7sEKRF5wgYLo6I2qD12pXnG4Aa0jDG6/8ZG/r 10a6q5RhCvtGa/Rpc4SLVnZ4vyWQYNJZK/f5q+AgCj2Ye0cGHvaEHU/Ce83agtxn9BQI CBOb+030WOer9RB+k34R7jRuLPLTabFn5uQ9u1MBJ+0iW+wLb0Kqa/WNJr7iDGSMK194 9TRAaZ8cDBbDnAF+PT+Kcku41M9IspG6RXjvddbXH4LPYbcuufAGBy5lu5Y+SgQzV1qq TPxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768109675; x=1768714475; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TM21KDyhcJUoAmM+A858DiQ2z1+q97+OMUE6Jv88IaM=; b=aSiHqwETBM63kBaw+CW1Q4FvUhBaB91DF/Di98l3qmv0J4icwTB4HU9tZ+QDx70sWN ksI9wVoUWGCnb9eBPPZc4SFquVd2crioJZZIIb+a4T59WDXErcJ9D1O9Wi1q8Tpe9KQd gXKwhU+0pa5CYleQVaplZ6QyesqzTsTY65StHUuilRoFhnY+cS/KZYQ6ir3hpPT2XOzD vyPbcJJBmKSQ7AQC27CcrthNexledluuNqZVhp/TO3m/5f0In1AMaFEZrl5DngY7YrES 4aLNfat8nQmvMv0uOxNU12nE3XzalDNTK1+b9cmFRgCKCiCWRuedt8ytBad8R8+Qs9T+ IHjA== X-Forwarded-Encrypted: i=1; AJvYcCVIlkJCxyHlKSqR0USpL+pniPMD5ZBI0M7wT6/M2/6WYdLc6BBUsccOl9Fgd1Ruo4kK93qxOCNX+lqqTOciMOebQGaB6g==@freebsd.org X-Gm-Message-State: AOJu0YyhZ42rOpiqQ4/rRgs4Zt63fmZ78xMkgZfA6U6uAv3vsyXfDy/7 X8OJZrOdohlq9cXwQLm1oop9cn+pEh9PkFTxd7gM/lRK41i7ASvmG1vl X-Gm-Gg: AY/fxX7vpRShccHj3JxGeBPZCBK+kadud8c7dCzCpWV6i0Hpe8B8IC4iSF/iIFE9dIB gYlTyj/N27YbSxCA/dYOr8EwqIoQcQirv/lruP90qYqfp6KYt5TySbCRFtzCxNpSjdhYCgug9zk ECPKUSqkW9LrCX3+59H/ZuqYOrQzAiGcWh0v5GQk2aeOZMf2UrB/Szzqizo2mNcZcdsDszTxOH3 02RT5HaQBtYNR7jtHNI5ltSBzEtnLY37qVGKuFFsjEm/18fTp7FBm4sFh5DhGIQEw5P+Ev1deqq 18WRs3SQyU47qruWdrUb44alGAvKSS5xmBK2/3o0SHQ3NWm7zCb6F4x9ajyNftYixf0ETtlwkJg B0ZlX44Z4iZHRF1DOstVRRAulrFcSFN5t97lMDQMGziokqSar4UiJShFu7LLqBLcDYkgu4mKDSc jf88XxOLDdJIeCJ9MqiC4H5DVawVY= X-Google-Smtp-Source: AGHT+IEYE0ELOOzWEOaqNBvIesd+lTe1ToCa09qBO60HM4NTeDte0MWd1Q3Rx9fkqYPN4zJ2253SQQ== X-Received: by 2002:a17:903:2986:b0:2a3:ccf5:6694 with SMTP id d9443c01a7336-2a3e39828e6mr173224265ad.3.1768109674739; Sat, 10 Jan 2026 21:34:34 -0800 (PST) Received: from smtpclient.apple ([45.90.222.74]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cd3284sm142760975ad.91.2026.01.10.21.34.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Jan 2026 21:34:34 -0800 (PST) From: "Enji Cooper (yaneurabeya)" Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_64F372D2-2D56-4D15-9FBC-6196F027B3BA" List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.4\)) Subject: Re: git: f224591746bd - main - Add ASMC_DEBUG make option Date: Sat, 10 Jan 2026 21:34:22 -0800 In-Reply-To: Cc: Enji Cooper , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org To: Olivier Certner References: <695c68c6.3ff5d.593fc2c7@gitrepo.freebsd.org> <1990810.vR5SVPPSqJ@ravel> X-Mailer: Apple Mail (2.3826.700.81.1.4) X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.50 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.995]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MV_CASE(0.50)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TO_DN_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::630:from]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ARC_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FROM_HAS_DN(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-Rspamd-Queue-Id: 4dpkjF0Tllz3M3p --Apple-Mail=_64F372D2-2D56-4D15-9FBC-6196F027B3BA Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jan 10, 2026, at 9:10=E2=80=AFPM, Enji Cooper (yaneurabeya) = wrote: >=20 > Hi Olivier, >=20 >> On Jan 9, 2026, at 8:44=E2=80=AFAM, Olivier Certner = wrote: >>=20 >> Hi Enji, >>=20 >>> The branch main has been updated by ngie: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Df224591746bdaf14ad5f63de4738a314= 6cc2f55f >>>=20 >>> commit f224591746bdaf14ad5f63de4738a3146cc2f55f >>> Author: Enji Cooper >>> AuthorDate: 2026-01-04 08:27:57 +0000 >>> Commit: Enji Cooper >>> CommitDate: 2026-01-06 01:43:04 +0000 >>>=20 >>> Add ASMC_DEBUG make option >>=20 >> This commit broke the i386 build. I've just committed a fix. Also, = I've restored 'device vt_efifb' in NOTES (under 'x86/' instead of = 'amd64/'), as AFAIK, NOTES should list all possible devices/options. >=20 > re: vt_efifb: what I did was removed the duplicate entry, since it was = already in the x86 one: = https://cgit.freebsd.org/src/tree/sys/x86/conf/NOTES#n332 . Admittedly, my commit message re: it already being in GENERIC was wrong. = It being in x86/NOTES is what mattered. >> Please make sure you also MFC the two following commits (67599eef01f5 = ("sys/x86/NOTES: Add vt_efifb"), fde9fe18219f i386 ("Fix kernel = compilation after introduction of ASMC_DEBUG option")) along with the = original one. >=20 > Sure =E2=80=94 although the correct fix would be to not build the = driver at all on i386, since it doesn=E2=80=99t support 32-bit CPUs. = Apple sold very few i386-based Intel chips before they transitioned to = amd64-only ones (it was only a matter of 8-9 months IIRC) and asmc(4) = doesn=E2=80=99t support any of the 32-bit chips (I checked). Cheers, -Enji= --Apple-Mail=_64F372D2-2D56-4D15-9FBC-6196F027B3BA Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On Jan 10, 2026, at 9:10=E2=80=AFPM, Enji Cooper = (yaneurabeya) <yaneurabeya@gmail.com> wrote:

Hi Olivier,

On Jan = 9, 2026, at 8:44=E2=80=AFAM, Olivier Certner <olce@freebsd.org> = wrote:

Hi = Enji,

The branch main has been updated = by ngie:

URL: = https://cgit.FreeBSD.org/src/commit/?id=3Df224591746bdaf14ad5f63de4738a314= 6cc2f55f

commit = f224591746bdaf14ad5f63de4738a3146cc2f55f
Author: =     Enji Cooper = <ngie@FreeBSD.org>
AuthorDate: 2026-01-04 08:27:57 = +0000
Commit:     Enji Cooper = <ngie@FreeBSD.org>
CommitDate: 2026-01-06 01:43:04 = +0000

   Add ASMC_DEBUG make = option

This commit broke the i386 build.  I've = just committed a fix.  Also, I've restored 'device vt_efifb' in = NOTES (under 'x86/' instead of 'amd64/'), as AFAIK, NOTES should list = all possible = devices/options.

re: = vt_efifb: what I did was removed the duplicate entry, since it was = already in the x86 one: https:/= /cgit.freebsd.org/src/tree/sys/x86/conf/NOTES#n332 .
<= /div>

Admittedly, my commit message re: it = already being in GENERIC was wrong. It being in x86/NOTES is what = mattered.

Please make sure = you also MFC the two following commits (67599eef01f5 ("sys/x86/NOTES: = Add vt_efifb"), fde9fe18219f i386 ("Fix kernel compilation after = introduction of ASMC_DEBUG option")) along with the original = one.

Sure =E2=80=94 although the correct fix would be = to not build the driver at all on i386, since it doesn=E2=80=99t support = 32-bit CPUs. Apple sold very few i386-based Intel chips before they = transitioned to amd64-only ones (it was only a matter of 8-9 months = IIRC) and asmc(4) doesn=E2=80=99t support any of the 32-bit chips (I = checked).

Cheers,
-Enji= --Apple-Mail=_64F372D2-2D56-4D15-9FBC-6196F027B3BA--