Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 05 Aug 2017 22:21:58 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 221015] [NEW PORT] mail/mailhog: MailHog development mail server
Message-ID:  <bug-221015-13-oeSEPu4qM8@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-221015-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-221015-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221015

Richard Gallamore <ultima@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ultima@freebsd.org

--- Comment #1 from Richard Gallamore <ultima@freebsd.org> ---
Hello, thanks you for your contributions and on this port. I found a few it=
ems
that needs to be adjusted before it is ready to be committed.


* Instead of including the bsd.port.pre.mk with an if, this could be made to
simply strip an i from the arch. ${ARCH:S/i//}. This should make it work wi=
th
both i386 and amd64.

* The USE_RC_SUBR belongs in the USES section and should come right after t=
he
ONLY_FOR_ARCHS.

* Group similar variables together with a space for these items,
EXTRACT_*(excluding EXTRACT_SUFX), NO_* and *_FILES.

* The append flag on SUB_FILES is not needed.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-221015-13-oeSEPu4qM8>