From owner-svn-src-all@freebsd.org Tue Apr 18 19:02:18 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 71D86D44A44; Tue, 18 Apr 2017 19:02:18 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-yb0-x22e.google.com (mail-yb0-x22e.google.com [IPv6:2607:f8b0:4002:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 292BD88C; Tue, 18 Apr 2017 19:02:18 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-yb0-x22e.google.com with SMTP id m133so554633ybb.1; Tue, 18 Apr 2017 12:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=GnGlPZcrMm+F02SY/FGNf6lf+CAyXtp4PmG3kiL998U=; b=N+oP8l/dcqORy5+9kbeDfngxCMe/N8R/5PIOMEhyEZ/7alz25JA0UQyKYvGLGegdY8 uOqjl9oSbEuWtPBnWLmOkVnWlbBZ/fcX45itB9oGwABWodSYVda0XTsO6JWNkvhDnimH UP3w/kR+r8fWDQRLB9nESFgTdVskPQZYjOmjVZywoPoK2AB/FxqV4p/7L/JP74iETkDO TKU5u2xZsmMrGxloVK898GzRnvKG8ENx/4XGPmXeY8bt0iuZZOi5YB4O45J97kUYLMG3 JbhHbzF+RJwl1rc4PlSxO9pcKfkyH8OcGfzaAraTwk9QlAW32WsrBz79CRRlYKya2Q1S LCBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=GnGlPZcrMm+F02SY/FGNf6lf+CAyXtp4PmG3kiL998U=; b=YQmJmRjE8x5ofWVUV68KP34WovAqONquxqYGBI96ogWYYKzCVIH7ymDCYlWntxGwLV Vm+ZRy7WMHTnlbyqkey0oCNukT7ynFf1Bfn/eR/C6dywOL7T6aQqD0ueNe0T4n8upioa UuBSGGXYU3UMgv6r1Y4rTNFmy6RlGSgOVVmesfMz6CISD9ugB9bd4+wfbWguiHQ9Y4nK 3Vew5K4VEEitgGUwhdboNcpbCq2c5dy7E5y5vQWbDVSdztrEJPSOohyurrE2ssv5BjfR k1TRukYcbM7M/BiUx1Ie6CFBHu+sdnw8jyUv7wLQRJPzOdmXHMwDW7Phy9kdubNqe4ly tRhg== X-Gm-Message-State: AN3rC/4oT8Fn3C8D+MmPy6GZOZFbSEq1qqOMGSYpw3VfVFjFaEUUlXKE U1lPeMMAJc1xsTbMDPIW5ArIcbJvWA== X-Received: by 10.37.234.72 with SMTP id o8mr19957951ybe.34.1492542137031; Tue, 18 Apr 2017 12:02:17 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.129.20.214 with HTTP; Tue, 18 Apr 2017 12:02:16 -0700 (PDT) In-Reply-To: <201610312309.u9VN9qGk027956@repo.freebsd.org> References: <201610312309.u9VN9qGk027956@repo.freebsd.org> From: Alan Somers Date: Tue, 18 Apr 2017 13:02:16 -0600 X-Google-Sender-Auth: kHPheU1Axr3_hEUfritvNI0WM9s Message-ID: Subject: Re: svn commit: r308155 - in head/sys: amd64/conf cam cam/scsi conf dev/mps geom geom/part kern sys vm To: "Conrad E. Meyer" Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2017 19:02:18 -0000 On Mon, Oct 31, 2016 at 5:09 PM, Conrad E. Meyer wrote: > Author: cem > Date: Mon Oct 31 23:09:52 2016 > New Revision: 308155 > URL: https://svnweb.freebsd.org/changeset/base/308155 > > Log: > Add BUF_TRACKING and FULL_BUF_TRACKING buffer debugging > > Upstream the BUF_TRACKING and FULL_BUF_TRACKING buffer debugging code. > This can be handy in tracking down what code touched hung bios and bufs > last. The full history is especially useful, but adds enough bloat that > it shouldn't be enabled in release builds. > > Function names (or arbitrary string constants) are tracked in a > fixed-size ring in bufs. Bios gain a pointer to the upper buf for > tracking. SCSI CCBs gain a pointer to the upper bio for tracking. > > Reviewed by: markj > Sponsored by: Dell EMC Isilon > Differential Revision: https://reviews.freebsd.org/D8366 > > Modified: > head/sys/amd64/conf/GENERIC > head/sys/amd64/conf/GENERIC-NODEBUG > head/sys/cam/cam_ccb.h > head/sys/cam/cam_periph.c > head/sys/cam/cam_xpt.c > head/sys/cam/scsi/scsi_da.c > head/sys/conf/options > head/sys/dev/mps/mps_sas.c > head/sys/geom/geom_dev.c > head/sys/geom/geom_disk.c > head/sys/geom/geom_io.c > head/sys/geom/geom_subr.c > head/sys/geom/geom_vfs.c > head/sys/geom/part/g_part.c > head/sys/kern/vfs_bio.c > head/sys/kern/vfs_cluster.c > head/sys/sys/bio.h > head/sys/sys/buf.h > head/sys/vm/vm_pager.c This change is causing panics when I try to create a zpool on an SSD. The SSD is obviously having problems; it fails UNMAP commands with ILLEGAL REQUEST, and then fails WRITE SAME with a timeout. The offending line is the biotrack call in scsi_da.c at line 4172; bp is apparently null. Could you please review this change and ensure that biotrack is appropriately guarded? -Alan