From owner-svn-src-all@freebsd.org Fri Nov 13 08:35:53 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B327CA2B4D6; Fri, 13 Nov 2015 08:35:53 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 45BB71DC2; Fri, 13 Nov 2015 08:35:53 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id tAD8ZhkA062233 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Fri, 13 Nov 2015 10:35:43 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua tAD8ZhkA062233 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id tAD8ZhV1062230; Fri, 13 Nov 2015 10:35:43 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 13 Nov 2015 10:35:43 +0200 From: Konstantin Belousov To: Hans Petter Selasky Cc: cem@FreeBSD.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290711 - head/sys/ofed/drivers/infiniband/core Message-ID: <20151113083543.GV2257@kib.kiev.ua> References: <201511121012.tACACKTI075143@repo.freebsd.org> <56459CEE.4090007@selasky.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56459CEE.4090007@selasky.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2015 08:35:53 -0000 On Fri, Nov 13, 2015 at 09:18:54AM +0100, Hans Petter Selasky wrote: > Hi, > > On 11/12/15 18:17, Conrad Meyer wrote: > > These should cast through (u)intptr_t rather than unsigned long. > > > > This is Linux code, and they use "unsigned long" for pointer casts > everywhere, trying to not break their style. > > BTW: I added to linux_compat.c: > > CTASSERT(sizeof(unsigned long) == sizeof(uintptr_t)); > > And it survived my "tinderbox" build and I was surprised! FreeBSD (at least currently) runs on two kinds of ABIs: ILP32 and LP64. ILP32 means that sizeof(int) == sizeof(long) == sizeof(void *) == 4. For LP64, sizeof(long) == sizeof(void *) == 8, while sizeof(int) == 4. We do not support anything else.