From owner-freebsd-current Wed Dec 6 6:37:27 2000 From owner-freebsd-current@FreeBSD.ORG Wed Dec 6 06:37:22 2000 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mailhub.fokus.gmd.de (mailhub.fokus.gmd.de [193.174.154.14]) by hub.freebsd.org (Postfix) with ESMTP id 77DE737B400; Wed, 6 Dec 2000 06:37:21 -0800 (PST) Received: from beagle (beagle [193.175.132.100]) by mailhub.fokus.gmd.de (8.8.8/8.8.8) with ESMTP id PAA10667; Wed, 6 Dec 2000 15:37:20 +0100 (MET) Date: Wed, 6 Dec 2000 15:37:19 +0100 (CET) From: Harti Brandt To: hackers@freebsd.org, current@freebsd.org Subject: ATM broken in -current Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Hi, the ATM stuff in /sys/dev/h{e,f}a and /sys/netatm seems to be seriously broken in current. A simple 'atm show config' command leads to a kernel panic. I have tracked down the problem (and had to learn, that bzero is a function pointer rather than a function on i386). I cannot track, how the problem was introduced, but it appears to be somehow connected to phk's header file reorganisation in the ATM code in october. Many of the files miss a include and give a missing prototyp warning for functions like splnet, printf, log, bzero... This appears to be deadly for bzero(), because this is a function pointer now. (I always had the fealing, that the ANSI-C syntax for calling functions through pointers is bad ( fooptr() instead of (*fooptr)()). Now I know why :-( ) Adding a #include to the following files seem to fix the problem: dev/hea/eni_intr.c dev/hea/eni_vcm.c netatm/atm_if.c netatm/atm_signal.c netatm/atm_socket.c netatm/atm_usrreq.c netatm/ipatm/ipatm_event.c netatm/ipatm/ipatm_if.c netatm/ipatm/ipatm_load.c netatm/ipatm/ipatm_output.c netatm/ipatm/ipatm_vcm.c netatm/spans/spans_cls.c netatm/spans/spans_subr.c netatm/uni/sscf_uni.c netatm/uni/sscf_uni_lower.c netatm/uni/sscf_uni_upper.c netatm/uni/sscop.c netatm/uni/sscop_lower.c netatm/uni/sscop_subr.c netatm/uni/sscop_upper.c netatm/uni/uni_load.c netatm/uni/uniarp_input.c netatm/uni/uniarp_output.c netatm/uni/uniarp_vcm.c netatm/uni/unisig_encode.c netatm/uni/unisig_mbuf.c netatm/uni/unisig_msg.c netatm/uni/unisig_print.c netatm/uni/unisig_proto.c netatm/uni/unisig_sigmgr_state.c Regards, harti -- harti brandt, http://www.fokus.gmd.de/research/cc/cats/employees/hartmut.brandt/private brandt@fokus.gmd.de, harti@begemot.org, lhbrandt@mail.ru To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message