From nobody Thu Sep 14 17:29:56 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rmkps0mdGz4tDbQ; Thu, 14 Sep 2023 17:29:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rmkps0KZ1z3XVk; Thu, 14 Sep 2023 17:29:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694712597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=asxXv0Cl8jQw8m+jZnVx7KVOuHw8+atAu+HGAUiG97U=; b=EMZST3lVLwHOYtcpV2TWsOfdT+6iiCZHOivuFDVslGZwBUwyTk+KL2n3GI43MBHMtxixZM kG9sjZWo2kMbCDzxfvQGTkhvONAQnD861EABTHXmyruk5k2r9fBiJjo5Mg7wC3GhrvvWYF blpeLS6gOgQVrfdOdyRGB/W+nY3VJNbkh7gIvXzg93Emnissasj1mIveraVjU4tUJ7RIu9 FbzWRzszd/LTnAoXG/xSGMBPG5/ejxbMlB4PNyp7wHOrSgST7wwzble2u1m2QgVL608wJx v8xZ8qRt9Pdxg7So182WSWADI4o315Oz1zO2p2NwrxtWGSkCZZG7lHbmrn1ZzA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1694712597; a=rsa-sha256; cv=none; b=uJHG2w1hYNmNqzj9E3IxLp+O0tds1FT3anOQpcae2Ttqny+vRirvVGF1B6hnWOSxdPUFtO KzqpSjs1CcuK2cfCSA9PMjGhVcvuFOmnpYpxYAQBkDXZUcMpL6pr7HRkk7gjw3kAfL6N9A HJFg8zhqKmYu04aAVMSZMUY0uvT2OC9mAtdh9sDnb//j7VXvGaW1+iRPVGdx1NyyBEdV8d CZRakQpa44r3B2oq66d8o8LEocnN9HpXFpn9Bsq8IOqlTWfWHAD/lgCLR/458eWedy0xtn THRHIIiiMhZwvswYzAzYMiUncN2z/qHqB30G+0+p7QC2sYq2k6AOcS0CQdU1kw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694712597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=asxXv0Cl8jQw8m+jZnVx7KVOuHw8+atAu+HGAUiG97U=; b=SQOQQ35qmTepnMwaNtWtkSQ+s93YRduaoqDECIlvA1pAFnn0qC8xPlYgcWrrWVSJaOyDeg DIA8J3r40/Rvq4u/ffOi03214/NII+5sVXKKK7QHJzvGoXZxLNAM2YRfnNvOPStu841Vme /3Fhno4sjW4oWLwKb2g1oqHbOlAuZLGvOwguZXQbK/nF3LGYK/KqAkNAy7W/PT96K0F++W 2YwRbLS/G1MfTGZJvACybJvDgrfIH0PFr414wU/c3+VDBJQd1vpGt8m5ZteWo4pfgLIvWL epNMAiM3dEvCvArkyrjlEMvRH9bcYZ+tAIbWL/mCLLrjsL9txnIycFxPYXBbvw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rmkpr6VvCz156f; Thu, 14 Sep 2023 17:29:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 38EHTuFC030543; Thu, 14 Sep 2023 17:29:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 38EHTu7r030540; Thu, 14 Sep 2023 17:29:56 GMT (envelope-from git) Date: Thu, 14 Sep 2023 17:29:56 GMT Message-Id: <202309141729.38EHTu7r030540@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mateusz Guzik Subject: git: 9dc0c983b093 - main - vfs: fix stale comment about freevnodes management List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9dc0c983b0931f359c2ff10d47ad835ef74e929a Auto-Submitted: auto-generated The branch main has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=9dc0c983b0931f359c2ff10d47ad835ef74e929a commit 9dc0c983b0931f359c2ff10d47ad835ef74e929a Author: Mateusz Guzik AuthorDate: 2023-09-14 17:28:32 +0000 Commit: Mateusz Guzik CommitDate: 2023-09-14 17:29:52 +0000 vfs: fix stale comment about freevnodes management --- sys/kern/vfs_subr.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index 4c9cb6200f10..ed478d33aed0 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -1444,12 +1444,12 @@ static struct proc *vnlruproc; static int vnlruproc_sig; /* - * The main freevnodes counter is only updated when threads requeue their vnode - * batches. CPUs are conditionally walked to compute a more accurate total. + * The main freevnodes counter is only updated when a counter local to CPU + * diverges from 0 by more than VNLRU_FREEVNODES_SLOP. CPUs are conditionally + * walked to compute a more accurate total. * - * Limit how much of a slop are we willing to tolerate. Note: the actual value - * at any given moment can still exceed slop, but it should not be by significant - * margin in practice. + * Note: the actual value at any given moment can still exceed slop, but it + * should not be by significant margin in practice. */ #define VNLRU_FREEVNODES_SLOP 126