Date: Sun, 22 Feb 2015 13:50:26 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 197707] [new port] devel/libosmo-netif Message-ID: <bug-197707-13-EJCh3StfOr@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-197707-13@https.bugs.freebsd.org/bugzilla/> References: <bug-197707-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D197707 --- Comment #1 from Jan Beich <jbeich@FreeBSD.org> --- Comment on attachment 153038 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D153038 libosmo-netif >XUSES=3D libtool pkgconfig >X >XUSE_AUTOTOOLS=3D aclocal autoconf automake libtoolize autoheader >XAUTOMAKE_ARGS=3D --gnu --add-missing --copy Can be replaced with USES=3D autoreconf >Xpost-patch: >X ${REINPLACE_CMD} -e 's|pkgconfigdir.*|pkgconfigdir =3D ${PREFIX}/libdata= /pkgconfig|g' \ >X ${WRKSRC}/Makefile.am Can be replaced with USES=3D pathfix PATHFIX_MAKEFILEIN=3D Makefile.am=20=20 >Xpost-stage: >X ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libosmonetif.so.2.0.0 Can be replaced with INSTALL_TARGET=3D install-strip >sed 's/^X//' >libosmo-netif/pkg-descr << '79ad83226ca6216d3244c7c44ff54313' >XLibrary containing common/shared code regarding network interface. >XDevelopment headers for Osmocom network interface. >XDebug symbols for Osmocom network interface. Why not put comment 0 description instead of debian/control shorts? We don't split packages into devel/debug. >X+++ configure.ac 2015-02-16 17:04:01.000000000 +0200 >X@@ -32,7 +32,7 @@ AC_COMPILE_IFELSE([AC_LANG_SOURCE([char=20 >X CFLAGS=3D"$saved_CFLAGS" >X AC_SUBST(SYMBOL_VISIBILITY) >X=20 >X-AC_CHECK_HEADER([endian.h], [], [AC_MSG_ERROR([endian.h not found!]) ]) >X+AC_CHECK_HEADER([sys/endian.h], [], [AC_MSG_ERROR([endian.h not found!])= ]) Use plural form and drop AC_MSG_ERROR e.g., AC_CHECK_HEADERS(endian.h sys/endian.h) >X--- src/rtp.c.orig 2014-09-08 08:52:08.000000000 +0300 >X+++ src/rtp.c 2015-02-16 11:54:11.000000000 +0200 >X@@ -1,6 +1,10 @@ >X #include <stdint.h> >X #include <sys/time.h> >X+#ifdef __FreeBSD__ Better use defines from autoheader e.g., #ifdef HAVE_CONFIG_H #include "config.h" #endif #ifdef HAVE_SYS_ENDIAN_H >X+#include <sys/endian.h> >X+#else >X #include <endian.h> >X+#endif >X+++ examples/ipa-stream-server.c 2015-02-16 17:05:21.000000000 +0200 >X@@ -4,6 +4,10 @@ >X #include <string.h> >X #include <unistd.h> >X #include <arpa/inet.h> >X+#ifdef __FreeBSD__ No need to guard POSIX headers. It'd also help other BSDs like DragonFly. >X+#include <sys/types.h> >X+#include <netinet/in.h> >X+#endif >X #include <netinet/tcp.h> >echo x - libosmo-netif/pkg-plist >sed 's/^X//' >libosmo-netif/pkg-plist << '589ab34feab31363be59acbd04f9baf2' >Xlib/libosmonetif.so >Xlib/libosmonetif.so.2 >Xlib/libosmonetif.so.2.0.0 Didn't portlint(1) warn you about USE_LDCONFIG ? --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-197707-13-EJCh3StfOr>