From owner-svn-src-all@freebsd.org Thu Jan 18 15:39:05 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7546BEB2F4C; Thu, 18 Jan 2018 15:39:05 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 5EF8F7389E; Thu, 18 Jan 2018 15:39:03 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id 0226d725; Thu, 18 Jan 2018 16:38:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=5jWsNOKtUEwjop6r5RuLQLqM7Nw=; b=P9zEXHXphizN2OZcNGO5ajGZIVrS CxY8P9t2bzttrVg74GyktKMgJ1vP7fCdSnYSROdh1Cx52fHvKogK0njRDYUOvg9s OvHUYaJL+Uq1Uy0bLxlZYbgbUcoFFufb+0V98b63WDw7Qwbn0FTOA0GIuWE0xSVo cZBuDxH5a8i6NaE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=H6aDpW22cRyjbJ4Hp+pM1fmFuE3KIFs6GfttYwK/aQ8jrx1XJKxVJB3C cuxLOy1FRRK+uQ4bFuYSrj/PFsxz+zFv0cat4wgAp5GEniE/8mA4PMI4Rs4odXQg +p9I3klZdWEyYZUe0iY12XLgn/mVkgO7Mw9Tt4/OeVz84Ydvdwg= Received: from arcadia (evadot.gandi.net [217.70.181.36]) by mail.blih.net (OpenSMTPD) with ESMTPSA id 9f75ccc1 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Thu, 18 Jan 2018 16:38:56 +0100 (CET) Date: Thu, 18 Jan 2018 16:38:55 +0100 From: Emmanuel Vadot To: Emmanuel Vadot Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328129 - head/sys/fs/nfsserver Message-Id: <20180118163855.b0a55427709c52d0ec2482c9@bidouilliste.com> In-Reply-To: <201801181528.w0IFSnWm053535@repo.freebsd.org> References: <201801181528.w0IFSnWm053535@repo.freebsd.org> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; amd64-portbld-freebsd12.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 15:39:05 -0000 On Thu, 18 Jan 2018 15:28:49 +0000 (UTC) Emmanuel Vadot wrote: > Author: manu > Date: Thu Jan 18 15:28:49 2018 > New Revision: 328129 > URL: https://svnweb.freebsd.org/changeset/base/328129 > > Log: > nfs: Do not printf each time a lock structure is freed during module unload > > There can be a lot of those structures and printing a line each time we free > one on module unload. Finishing the sentence : There can be a lot of those structures and printing a line each time we free one on module unload is really time consuming, especially when you have a serial console plugged in. Sponsored by: Gandi.net > MFC after: 3 days > > Modified: > head/sys/fs/nfsserver/nfs_nfsdstate.c > > Modified: head/sys/fs/nfsserver/nfs_nfsdstate.c > ============================================================================== > --- head/sys/fs/nfsserver/nfs_nfsdstate.c Thu Jan 18 15:15:35 2018 (r328128) > +++ head/sys/fs/nfsserver/nfs_nfsdstate.c Thu Jan 18 15:28:49 2018 (r328129) > @@ -5799,10 +5799,8 @@ nfsrv_throwawayallstate(NFSPROC_T *p) > * Also, free up any remaining lock file structures. > */ > for (i = 0; i < nfsrv_lockhashsize; i++) { > - LIST_FOREACH_SAFE(lfp, &nfslockhash[i], lf_hash, nlfp) { > - printf("nfsd unload: fnd a lock file struct\n"); > + LIST_FOREACH_SAFE(lfp, &nfslockhash[i], lf_hash, nlfp) > nfsrv_freenfslockfile(lfp); > - } > } > } > -- Emmanuel Vadot