Date: Thu, 18 Jan 2018 16:38:55 +0100 From: Emmanuel Vadot <manu@bidouilliste.com> To: Emmanuel Vadot <manu@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328129 - head/sys/fs/nfsserver Message-ID: <20180118163855.b0a55427709c52d0ec2482c9@bidouilliste.com> In-Reply-To: <201801181528.w0IFSnWm053535@repo.freebsd.org> References: <201801181528.w0IFSnWm053535@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 18 Jan 2018 15:28:49 +0000 (UTC) Emmanuel Vadot <manu@FreeBSD.org> wrote: > Author: manu > Date: Thu Jan 18 15:28:49 2018 > New Revision: 328129 > URL: https://svnweb.freebsd.org/changeset/base/328129 > > Log: > nfs: Do not printf each time a lock structure is freed during module unload > > There can be a lot of those structures and printing a line each time we free > one on module unload. Finishing the sentence : There can be a lot of those structures and printing a line each time we free one on module unload is really time consuming, especially when you have a serial console plugged in. Sponsored by: Gandi.net > MFC after: 3 days > > Modified: > head/sys/fs/nfsserver/nfs_nfsdstate.c > > Modified: head/sys/fs/nfsserver/nfs_nfsdstate.c > ============================================================================== > --- head/sys/fs/nfsserver/nfs_nfsdstate.c Thu Jan 18 15:15:35 2018 (r328128) > +++ head/sys/fs/nfsserver/nfs_nfsdstate.c Thu Jan 18 15:28:49 2018 (r328129) > @@ -5799,10 +5799,8 @@ nfsrv_throwawayallstate(NFSPROC_T *p) > * Also, free up any remaining lock file structures. > */ > for (i = 0; i < nfsrv_lockhashsize; i++) { > - LIST_FOREACH_SAFE(lfp, &nfslockhash[i], lf_hash, nlfp) { > - printf("nfsd unload: fnd a lock file struct\n"); > + LIST_FOREACH_SAFE(lfp, &nfslockhash[i], lf_hash, nlfp) > nfsrv_freenfslockfile(lfp); > - } > } > } > -- Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180118163855.b0a55427709c52d0ec2482c9>