From owner-freebsd-stable@FreeBSD.ORG Tue Apr 3 23:03:29 2007 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7AB4A16A401 for ; Tue, 3 Apr 2007 23:03:29 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outS.internet-mail-service.net (outS.internet-mail-service.net [216.240.47.242]) by mx1.freebsd.org (Postfix) with ESMTP id 645B513C45A for ; Tue, 3 Apr 2007 23:03:29 +0000 (UTC) (envelope-from julian@elischer.org) Received: from mx0.idiom.com (HELO idiom.com) (216.240.32.160) by out.internet-mail-service.net (qpsmtpd/0.32) with ESMTP; Tue, 03 Apr 2007 15:33:41 -0700 Received: from [10.251.22.38] (nat.ironport.com [63.251.108.100]) by idiom.com (Postfix) with ESMTP id 5510C125B2F; Tue, 3 Apr 2007 16:03:28 -0700 (PDT) Message-ID: <4612DD3F.1010401@elischer.org> Date: Tue, 03 Apr 2007 16:03:27 -0700 From: Julian Elischer User-Agent: Thunderbird 1.5.0.10 (Macintosh/20070221) MIME-Version: 1.0 To: Julian Elischer References: <200704011107.22750.joao@matik.com.br> <200704030239.l332dC89044128@lava.sentex.ca> <4611FAB6.4090201@elischer.org> <46120138.5090702@yandex.ru> <4612238D.6070504@elischer.org> In-Reply-To: <4612238D.6070504@elischer.org> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 8bit Cc: freebsd-stable@freebsd.org, "Andrey V. Elsukov" , julian@freebsd.org, JoaoBR Subject: Re: ipfw add pipe broken in RELENG_6 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2007 23:03:29 -0000 Julian Elischer wrote: > Andrey V. Elsukov wrote: >> Julian Elischer пишет: >>> somewhere between my MFC testing and the commits there seems to have >>> been a screwup. >>> I think it happenned because I reverted a MFC out of my list of MFC's >>> to do after >>> I had done some tests because they causled a failure and I hadn't >>> realised that >>> they affected this code too. >>> >>> I'm doing testing now and should be able to confirm this in a short >>> while. >> >> Hi, Julian! >> >> Seems, that converting from time_second to time_uptime broke >> `ipfw -t show'. >> Now we have one PR: >> http://www.freebsd.org/cgi/query-pr.cgi?pr=111177 >> >> And i see similar problem on the my CURRENT. I have committed a fix in -current please check ip_fw2.c version 1.162 If this meets with general happiness I will re-MFC this 1.112 along with this fix to it. >> > > yeah I seem to have MFC'd a BUG.. > I confirmed they behaved the same. but I was looking at binary data > and didn't notice the date.. > > I'm preparing a revert, however it is a no-win situation as that leaves > you open to sessions timing out immediately when the time is changed > forward. > > So, which is more important? > accurate timeouts or accurate reporting? > > Ont thing that COULD be done would be to add the boot-time to the reported > times. this would never let a session time out too early, but would give > slightly misleading report numbers if the time is adjusted. They would > 'adjust' to the same offset against the 'new time'. > i.e. if it shows 2 hours before "now" before the change it will show 2 > hours before the "new now" after the time is changed. This may be > acceptable.