From owner-freebsd-net@FreeBSD.ORG Wed Aug 27 07:53:36 2014 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 84BF1351 for ; Wed, 27 Aug 2014 07:53:36 +0000 (UTC) Received: from mail-qc0-x235.google.com (mail-qc0-x235.google.com [IPv6:2607:f8b0:400d:c01::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3E53B3037 for ; Wed, 27 Aug 2014 07:53:36 +0000 (UTC) Received: by mail-qc0-f181.google.com with SMTP id x13so16626577qcv.40 for ; Wed, 27 Aug 2014 00:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=+aT+3ppVPh9Rd4YYaCsXiiGqEZtpR5FQEgocZ3ostYI=; b=ReIqmclI/tmpbM1GxPfeYJ6usxC3pv1RqxRVWxKPZS8Zw2d0wtVKUTRC3LX9PzZS4k arCm+Adoele8etxcIo3Jl6aWzccr4gavbvKORnwrmTr6IKqUj4ngiw5JcDmhhOldYOqS ogq406qP+xsbiQMc6WX8frYnnvYyG+oDYfKiOEjfiZTUKuj8bAvZ/skVBRwUYRpJpsrp NDdf/QWqewWtxox/WeyPKTTUGn6PTjaK70sMXsiJOFWjK4Ei6m5xALDF7Y1C/WOjUABG 2uSNnWtl2BI13c8Fs7XRiYPFFpc8Uyr6nJBO0qqrBw9fQpConIQZY7b1R1G8ywtPcA+I jmvw== MIME-Version: 1.0 X-Received: by 10.224.46.8 with SMTP id h8mr56078334qaf.6.1409126015290; Wed, 27 Aug 2014 00:53:35 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.39.139 with HTTP; Wed, 27 Aug 2014 00:53:35 -0700 (PDT) In-Reply-To: <3ABE6D0D-1D98-425B-BDAD-8D1B9026AD8F@netapp.com> References: <259C9434-C6FE-42EA-823D-ECB024DBF3D7@netapp.com> <814E0886-1B6B-4316-8BAB-684DAFDE1983@netapp.com> <20140826145517.GD12732@gmail.com> <76D986F7-72A8-4ABE-8731-064C6C77A56F@netapp.com> <3ABE6D0D-1D98-425B-BDAD-8D1B9026AD8F@netapp.com> Date: Wed, 27 Aug 2014 00:53:35 -0700 X-Google-Sender-Auth: JCqgdeEY-MpFHw8Zpj7WAQ693HY Message-ID: Subject: Re: Patches for RFC6937 and draft-ietf-tcpm-newcwv-00 From: Adrian Chadd To: "Eggert, Lars" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Tom Jones , FreeBSD Net X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Aug 2014 07:53:36 -0000 Ok. Is it the same patch you sent out in Feb? -a On 27 August 2014 00:43, Eggert, Lars wrote: > Not as far as I know. > > Lars > > On 2014-8-27, at 9:39, Adrian Chadd wrote: > >> Is there a PR for it? >> >> >> -a >> >> >> On 27 August 2014 00:23, Eggert, Lars wrote: >>> It would be great if people could also review Aris' PRR patch - RFC6937= has been out for a while. >>> >>> Lars >>> >>> >>> >>> >>> On 2014-8-26, at 20:09, Adrian Chadd wrote: >>> >>>> Hi! >>>> >>>> I'm going to merge Tom's work in a week unless someone gives me a >>>> really good reason not to. >>>> >>>> I think there's been enough work and discussion about it since the >>>> first post from Lars in Feburary and enough review opportunity. >>>> >>>> >>>> -a >>>> >>>> >>>> On 26 August 2014 07:55, Tom Jones wrote: >>>>> On Tue, Aug 26, 2014 at 02:43:49PM +0000, Eggert, Lars wrote: >>>>>> Hi, >>>>>> >>>>>> the newcwv patch is probably stale now with Tom Jones' recent patch = based on >>>>>> a more up-to-date version of the Internet-Draft, but the PRR patch s= hould >>>>>> still be useful? >>>>> >>>>> My newcwv patch is much more up to date than Aris's, but it is slight= ly >>>>> different in implementation. I have had a few suggestions from Adrian= , but he >>>>> couldn't comment on how it relates to the tcp internals. >>>>> >>>>> There is a PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D19= 1520 >>>>> >>>>> The biggest difference in structure between mine and Aris's patch is = the use of >>>>> tcp timers. It would be good to hear if my approach or Aris's is pref= ered. >>>>> >>>>>> On 2014-6-19, at 23:35, George Neville-Neil w= rote: >>>>>> >>>>>>> On 4 Feb 2014, at 1:38, Eggert, Lars wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> below are two patches that implement RFC6937 ("Proportional Rate R= eduction for TCP") and draft-ietf-tcpm-newcwv-00 ("Updating TCP to support = Rate-Limited Traffic"). They were done by Aris Angelogiannopoulos for his M= S thesis, which is at https://eggert.org/students/angelogiannopoulos-thesis= .pdf. >>>>>>>> >>>>>>>> The patches should apply to -CURRENT as of Sep 17, 2013. (Sorry fo= r the delay in sending them, we'd been trying to get some feedback from com= mitters first, without luck.) >>>>>>>> >>>>>>>> Please note that newcwv is still a work in progress in the IETF, a= nd the patch has some limitations with regards to the "pipeACK Sampling Per= iod" mentioned in the Internet-Draft. Aris says this in his thesis about wh= at exactly he implemented: >>>>>>>> >>>>>>>> "The second implementation choice, is in regards with the measurem= ent of pipeACK. This variable is the most important introduced by the metho= d and is used to compute the phase that the sender currently lies in. In or= der to compute pipeACK the approach suggested by the Internet Draft (ID) is= followed [ncwv]. During initialization, pipeACK is set to the maximum poss= ible value. A helper variable prevHighACK is introduced that is initialized= to the initial sequence number (iss). prevHighACK holds the value of the h= ighest acknowledged byte so far. pipeACK is measured once per RTT meaning t= hat when an ACK covering prevHighACK is received, pipeACK becomes the diffe= rence between the current ACK and prevHighACK. This is called a pipeACK sam= ple. A newer version of the draft suggests that multiple pipeACK samples c= an be used during the pipeACK sampling period." >>>>>>>> >>>>>>>> Lars >>>>>>>> >>>>>>>> >>>>>>>> [prr.patch] >>>>>>>> >>>>>>>> [newcwv.patch] >>>>>>> >>>>>>> Apologies for not looking at this as yet. It is now closer to the = top of my list. >>>>>>> >>>>>>> Best, >>>>>>> George >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Tom >>>>> @adventureloop >>>>> adventurist.me >>>>> >>>>> :wq >>>>> _______________________________________________ >>>>> freebsd-net@freebsd.org mailing list >>>>> http://lists.freebsd.org/mailman/listinfo/freebsd-net >>>>> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org= " >>> >>> >