From owner-svn-ports-all@FreeBSD.ORG Wed Feb 25 16:51:18 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5F58A9CB for ; Wed, 25 Feb 2015 16:51:18 +0000 (UTC) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 268082B1 for ; Wed, 25 Feb 2015 16:51:17 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id AC3B62109E for ; Wed, 25 Feb 2015 11:51:14 -0500 (EST) Received: from web3 ([10.202.2.213]) by compute5.internal (MEProxy); Wed, 25 Feb 2015 11:51:15 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=message-id:x-sasl-enc:from:to:cc :mime-version:content-transfer-encoding:content-type:in-reply-to :references:subject:date; s=smtpout; bh=Ka4Qnd0vivpctvefcJyld8lm Nxo=; b=PTBLGFbD3IgsYDexCCxhUhCKDfdA8IK0IPHZKMBb8ltJ5s7uAmA7+qtv fanWq77SSOd46CiyK2xYZxcGdfhAPuW7mV6vbkBCFVC2p80blayXVKpiA7aMJOlt 5YeI2EoF//YPGp83gJ2B3x8PozIF46TIuCWWpfAFIbxBZIiU2cU= Received: by web3.nyi.internal (Postfix, from userid 99) id 5701411BAB6; Wed, 25 Feb 2015 11:51:15 -0500 (EST) Message-Id: <1424883075.3274564.232309289.0D19C5CC@webmail.messagingengine.com> X-Sasl-Enc: ZwBLibSSjdltsfLL6nTXIO31mQhPS8wLlHtzi9mXxPje 1424883075 From: Mark Felder To: Mathieu Arnold , marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: MessagingEngine.com Webmail Interface - ajax-4ba7306c In-Reply-To: <51E869A1A81020445F3AC58F@ogg.in.absolight.net> References: <201502251444.t1PEig7Z044705@svn.freebsd.org> <54EDE96B.2080703@marino.st> <54EDEA5B.7090907@marino.st> <1424879169.3258486.232296941.283231A2@webmail.messagingengine.com> <51E869A1A81020445F3AC58F@ogg.in.absolight.net> Subject: Re: svn commit: r379920 - in head/dns/ldns: . files Date: Wed, 25 Feb 2015 10:51:15 -0600 Cc: jaap@NLnetLabs.nl X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Feb 2015 16:51:18 -0000 On Wed, Feb 25, 2015, at 10:06, Mathieu Arnold wrote: > +--On 25 f=E9vrier 2015 09:46:09 -0600 Mark Felder > wrote: > | I'm not the maintainer; merely applied waiting maintainer-approved > | patches. It sounds like we should open a PR to address these issues, > | though. >=20 > Well, you're allowed to change a maintainer approved patch to fit our > rules/guidelines. >=20 Yeah, I'm not trying to weasel my way out of that. I take responsibility for not thoroughly reviewing the patch; it passed the smell test by building on 9.x and 10.x with both openssl and libressl :-) After a quick chat in IRC it appears that ldns is not respecting MAKE_ENV when it gets to that point, so the BSD_INSTALL_* are not available. :-( <@bapt> the port would need a lot of love :) Now I have to flog myself for leaving a spaces -> tab I failed to correct in the port Makefile