From owner-svn-src-all@freebsd.org Fri Jan 25 18:40:13 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1D0E314BE38B; Fri, 25 Jan 2019 18:40:13 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6C94469DDF; Fri, 25 Jan 2019 18:40:12 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-wm1-x329.google.com with SMTP id y139so7645760wmc.5; Fri, 25 Jan 2019 10:40:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=F72dsnYucTEvLWFiMeZq782aDMFJuV0wADbrGL6ZDSg=; b=bDdixyN0ldIot7x7Qq59MR5R8Lxsh3orxHc/L4nEhC73vGNPOBDF6oqVitwXdHnIhn niqdcf7zoS9OQUYHHtl4OKDDa0wPE5mlGqSatlhEsFMk+NUvrnc1mBpdBZ19uESFZJ0r mSj5h/zUgOeoIHqU5oPJDw83JdGtqvNBWNacmk3tjZ+PAuULRGJclay5VVo8ngAkpcA9 b3/sLwdcCWTw1cZwD5LuUyU30tOPgn2oyT6Wzsc0IYkvFXhnwszJeC7Xtlli61EChV2P pWRO2sCH8PAIHjnpx79h3AY0lJFWxdyb9Xdp9fZjffCN5UEw4isl70HUDmZJkgqYoumB W5TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=F72dsnYucTEvLWFiMeZq782aDMFJuV0wADbrGL6ZDSg=; b=UdKwfZfCpXlg9VzbWyjPH426ldVywjD+ckviXOXDpLJzqKe9lJfKohwkJCg6SilP13 Ffh4dGewbwog8yH79DfItt75aoMRN4bpd3CqBK0JqdGdGOgWHmwO5FYOxVwxSqjLUJYe byKWq8yzgfx7aiwyikpY6OaJaDZlfl+l9DlwEBoeoZn7bxmJds845aOqHkh+xeY0fKg6 VybAXqAQKNvYVhtTYq3mjLKPjI9sjjG0l7hon0bixHZ96Egtu7Kif4F7xLP6IGOh4Kq8 dDnpcfW0W78eGy8vZW+6wxGHi5p8/9USinIrQy5PJlcDGuv6Mbzcxs8Pndms4SKad0Os tYgg== X-Gm-Message-State: AJcUukfxesmQp2uPV8grSMVdKw+m99+FcGmaIWEK2HIymqc7kmoI2neP eEoO4eDRMVsgov2LDzOl799pTMcG X-Google-Smtp-Source: ALg8bN4zhBwdam0x4vW04sqr3kgH5OqeCZbI9dYvXsxrsOyfXAcRlVPMgSUIdlFejhyr1MFWbTs0uA== X-Received: by 2002:a1c:13d1:: with SMTP id 200mr7738419wmt.4.1548441610752; Fri, 25 Jan 2019 10:40:10 -0800 (PST) Received: from v2 (cpc92302-cmbg19-2-0-cust461.5-4.cable.virginm.net. [82.1.209.206]) by smtp.gmail.com with ESMTPSA id v16sm87112016wrs.75.2019.01.25.10.40.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Jan 2019 10:40:09 -0800 (PST) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Fri, 25 Jan 2019 06:51:56 +0000 From: Edward Tomasz =?utf-8?Q?Napiera=C5=82a?= To: Alexey Dokuchaev Cc: rgrimes@freebsd.org, src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343416 - head/bin/sh Message-ID: <20190125065156.GA25806@v2> Mail-Followup-To: Alexey Dokuchaev , rgrimes@freebsd.org, src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201901251339.x0PDd5sG088601@pdx.rh.CN85.dnsmgr.net> <20190125060258.GA25351@v2> <20190125181320.GA5015@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190125181320.GA5015@FreeBSD.org> User-Agent: Mutt/1.11.2 (2019-01-07) X-Rspamd-Queue-Id: 6C94469DDF X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.96)[-0.963,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 18:40:13 -0000 On 0125T1813, Alexey Dokuchaev wrote: > On Fri, Jan 25, 2019 at 06:02:58AM +0000, Edward Napierala wrote: > > The aliases are gone, let's continue on the remaining bits below. > > They are not gone, they were commented out; also, bogus double linefeeds > are not gone. Yeah, I've matched the existing comment style in that file. > But most importantly, this whole file is useless and IMHO > should just be removed. /bin/sh is not supposed to be one's interactive > shell. Of course it is an interactive shell. We've been using it as the default interactive shell for non-root accounts since... ages. > > It is alien, because it's different from their experience > > from other systems they are used to. > > This argument does not really hold because /bin/sh is not... see above. > > > It doesn't affect existing installs. It doesn't affect people > > who run the default root shell (tcsh), nor folks who use shells > > AFAICT default root shell is /bin/csh, not tcsh. ;-) But that also Our csh _is_ tcsh. > means that /usr/src/bin/sh/dot.shrc doesn't have to exist: those who > change the root shell should either pick another interactive shell, > or if they want /bin/sh be ready to deal with sanitary environment. See above. > > And for folks who do have their own tree with their preferred > > /root/.shrc to "make distribution" from, it should actually make > > their diff to upstream smaller. > > I don't like extra files, esp. configuration files that look like they > are for interactive shell while our /bin/sh is in fact not. This is > confusing, and FreeBSD is not supposed to be confusing. Again, sh(1) is an interactive shell. > > It is a syntax problem: > > > > trasz@v2:~ % while :; do date; sleep 1; done > > while: Expression Syntax. > > do: Command not found. > > done: Command not found. > > Are you trying to use sh(1) loop in (t)csh? Why? And what does it have > to do with the /usr/src/bin/sh/dot.shrc issue? I'm trying to explain the basic problem with our default shell: it doesn't work, because it can't handle what people call the shell syntax.