From owner-cvs-all Sat Jan 26 4:53: 2 2002 Delivered-To: cvs-all@freebsd.org Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11]) by hub.freebsd.org (Postfix) with SMTP id C20DC37B402; Sat, 26 Jan 2002 04:52:57 -0800 (PST) Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP id ; 26 Jan 2002 12:52:56 +0000 (GMT) To: Julian Elischer Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm.h In-reply-to: Your message of "Fri, 25 Jan 2002 16:30:32 PST." X-Request-Do: Date: Sat, 26 Jan 2002 12:52:56 +0000 From: David Malone Message-ID: <200201261252.aa17054@salmon.maths.tcd.ie> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > In the kernel it is usual to have parameter names in prototypes > (it was in style) It tends to keep people using standard names for certain > things... OK, but I think something in userland sees this declaration and gcc whines about it. I might have made the change originally when I was playing with WARNS and gcc3. Should this declaration be protected by a #ifdef _KERNEL? I can go an dig up what produced the warning if you think that I would be better fixing it some other way. (Also, the parameter name was "kmi" and the line before in vm.h says "extern struct kva_md_info kmi;", so the parameter would always be shadowing a global variable. I guess that wouldn't have been ideal.) David. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message