From nobody Mon Apr 10 12:39:00 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pw7nc352Bz45BgK for ; Mon, 10 Apr 2023 12:39:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pw7nc0zGvz3h7X for ; Mon, 10 Apr 2023 12:39:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681130340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pQ3t4703neWRcXhfuc6OMt5rn/uq2IU8/5jLDySqzVA=; b=rAtSI1EG6/KMaivr97E2YMsZ92iyjF4smP/Tl0mNK6dvyLpIChVGRvn4TdbPTlr5ANbLpi +HLIEMCnB0i6w6mqrObMfV2nzp4fy0jDbGRrBBCMjWPrBJPFH+vUvE1dRWj9IHu1HtWnXa hqE1UpctnHPBmMUM8x8WWiTmmfrwf/cXn9o4+KMteFal8WLMAPlz8xCkTlMHrQ4ZHTOJv1 2DxwOIn089XEuXbsN/1sryMlnYNcMhFARa0ZGbp6tGCnXnAWMVFbLaZLQzs+wGSH5xRe1L q288rX+pOTJoa6GWPjyW3Lg3aKZQYYUokUDs6EePXz/vZD3OzDoBpn8JlmeW3Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681130340; a=rsa-sha256; cv=none; b=uVHeDTfCzTvLxyYz5f/ZPx1XtOq+Srqi8K8wuuROnKoRzIE9ysGyxUXdE9XRd4r+c8t/yb gvye+Pdy0Ewame2IxSSjIYnj6UCeesOb6EJiocRx07/dM7Y1RZag7Cv7Or2CcAb1RDdxA5 MsHnYrJnhVp26gzIcpwoGgM0cuiLClxx41C0bPRK/x2LI77nAv8oE2YqyhuK6VJLkihSj5 kQQDkH+X5W+FFMTF+62cYlCOTyUKD9Uuf3vuO43VJLdlMhc8sbKL59cQBLqdV77vlIi5Ub ogJMvg7fF7BCEYvUGySsRpIMClHJFUEUrir9yGZQfPUadsinEwBgzkTEXHxSpA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Pw7nc00mjzq2F for ; Mon, 10 Apr 2023 12:39:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 33ACcx4Z064134 for ; Mon, 10 Apr 2023 12:38:59 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 33ACcxpl064133 for bugs@FreeBSD.org; Mon, 10 Apr 2023 12:38:59 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 270736] if_epair(4): Unexpected double tagged ICMP requests Date: Mon, 10 Apr 2023 12:39:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kp@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kp@freebsd.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc assigned_to bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270736 Kristof Provost changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kp@freebsd.org Assignee|bugs@FreeBSD.org |kp@freebsd.org Status|New |Open --- Comment #1 from Kristof Provost --- That's a fun one. It looks like the problem is actually on the receive side, in that we don't clear the M_VLANTAG from m->m_flags and end up thinking there's an extra vl= an on the RX side. if_epair already has some code to remove tags and such when handing a packet over to the receive path, but it didn't clear the vlan information. (Arguab= ly we could also clear it on the network stack side, but this is pretty specif= ic to if_epair.) I'm testing this now: diff --git a/sys/net/if_epair.c b/sys/net/if_epair.c index aeed993249f5..21c0c598e8d4 100644 --- a/sys/net/if_epair.c +++ b/sys/net/if_epair.c @@ -140,6 +140,11 @@ epair_clear_mbuf(struct mbuf *m) m->m_pkthdr.csum_flags &=3D ~CSUM_SND_TAG; } + /* Clear vlan information. */ + m->m_flags &=3D ~M_VLANTAG; + if (m->m_flags & M_PKTHDR) + m->m_pkthdr.ether_vtag =3D 0; + m_tag_delete_nonpersistent(m); } --=20 You are receiving this mail because: You are the assignee for the bug.=