From owner-freebsd-bugs@FreeBSD.ORG Sun Oct 26 14:19:50 2014 Return-Path: Delivered-To: freebsd-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5E0FC436 for ; Sun, 26 Oct 2014 14:19:50 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 288ECCC6 for ; Sun, 26 Oct 2014 14:19:50 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s9QEJoND088858 for ; Sun, 26 Oct 2014 14:19:50 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 194606] filesystem unmount deadlock on 10.1 and head when TRIM enabled at unmount after r268815, MFC of 268205 Date: Sun, 26 Oct 2014 14:19:50 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RC2 X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: madpilot@FreeBSD.org X-Bugzilla-Status: In Discussion X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Oct 2014 14:19:50 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194606 Guido Falsi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Triage |In Discussion --- Comment #2 from Guido Falsi --- (In reply to Warner Losh from comment #1) > If you disable trim, does the problem go away? Yes, it does go away. It easy to test, since simply mounting thee FS, editing a file with vi and unmounting it causes the panic, if not at first try it does in 2-3. > > I had a hard time scrounging up a CF card to test with on a SATA system. > > I'm guessing that I've dropped a biodone given the debug you've posted. Maybe, unluckily I don't know much about the kernel and the VFS system, so I can't really help with the code. Looking at it I noticed that before that commit thee value of softc->trim_running is changed before any operation is performed, while after the patch the code calls the new functions performing operation before changing that value, which is changed after the conditional (line 1506). It could be unrelated, I don't really know what that variable means, but could it be related? If you have some patch I'll be happy to test and report back. I can perform any kind of test, since this is not production hardware. -- You are receiving this mail because: You are the assignee for the bug.