From owner-cvs-all Fri May 10 18:37:59 2002 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18]) by hub.freebsd.org (Postfix) with ESMTP id 0AFBA37B403; Fri, 10 May 2002 18:37:51 -0700 (PDT) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [IPv6:fec0::1:12]) by Awfulhak.org (8.12.3/8.12.3) with ESMTP id g4B1bnfK057742; Sat, 11 May 2002 02:37:49 +0100 (BST) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.12.3/8.12.3) with ESMTP id g4B1binA007822; Sat, 11 May 2002 02:37:44 +0100 (BST) (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200205110137.g4B1binA007822@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: John Baldwin Cc: Brian Somers , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Joerg Wunsch Subject: Re: cvs commit: src/sys/isa fd.c fdreg.h In-Reply-To: Message from John Baldwin of "Fri, 10 May 2002 20:29:49 EDT." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 11 May 2002 02:37:43 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > > On 11-May-2002 Brian Somers wrote: > >> joerg 2002/05/10 10:56:39 PDT > >> > >> Modified files: > >> sys/isa fd.c fdreg.h > >> Log: > >> Change the PIO loops from a hard counter into a loop that calls DELAY() > >> in each cycle, with a tunable max cycle count defined in fdreg.h. > >> > >> This is said to fix the problem on some Compaq hardware (and perhaps > >> on other machines using the Natsemi PC87317 chip) where the fdc(4) > >> driver failed to operate at all. > >> > >> PR: kern/21397 > >> Submitted by: Jung-uk Kim > >> MFC after: 3 days > >> > >> Revision Changes Path > >> 1.229 +14 -8 src/sys/isa/fd.c > >> 1.16 +12 -0 src/sys/isa/fdreg.h > > > > As fdc is also a module, would it be better to call tsleep() instead > > of delay if (!cold) ? Like in sys/dev/digi/digi.c:digi_delay()... > > Hmm, we should come up with the real fix for this quick so as to avoid > propagating that hack any farther than we have to. :-/ (Not picking on > you Brian). Yes. NetBSD has an MD delay() function in sys/arch/*/{,*/}clock.c, prototyped in sys/arch/*/include/cpu.h. I guess I could have a go at bringing that into FreeBSD. > -- > > John Baldwin <>< http://www.FreeBSD.org/~jhb/ > "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ -- Brian http://www.freebsd-services.com/ Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message