From owner-freebsd-current@freebsd.org Wed Aug 14 17:55:06 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6AF8AB4104 for ; Wed, 14 Aug 2019 17:55:06 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 467y0V2F1yz4fHy for ; Wed, 14 Aug 2019 17:55:06 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 4A788B4100; Wed, 14 Aug 2019 17:55:06 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4A281B40FF; Wed, 14 Aug 2019 17:55:06 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (mail.daemonic.se [176.58.89.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 467y0T6Mjnz4fHx; Wed, 14 Aug 2019 17:55:05 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 467y0R4lp7z3l2k; Wed, 14 Aug 2019 17:55:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([IPv6:::1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [IPv6:::1]) (amavisd-new, port 10587) with ESMTPS id 3ygrqJCm1XTt; Wed, 14 Aug 2019 17:55:03 +0000 (UTC) Received: from garnet.daemonic.se (unknown [IPv6:2001:470:dca9:201:99b8:b5f9:82da:aca0]) by mail.daemonic.se (Postfix) with ESMTPSA id 467y0Q6f3Wz3c7W; Wed, 14 Aug 2019 17:55:02 +0000 (UTC) Subject: Re: HEADSUP: drm-current-kmod now installs sources To: Emmanuel Vadot , John Baldwin Cc: x11@FreeBSD.org, current@FreeBSD.org, Ian Lepore References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> From: Niclas Zeising Message-ID: Date: Wed, 14 Aug 2019 19:55:02 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 467y0T6Mjnz4fHx X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-2.94 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.94)[-0.943,0]; ASN(0.00)[asn:36236, ipnet:176.58.89.0/24, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 17:55:06 -0000 On 2019-08-14 19:23, Emmanuel Vadot wrote: > On Wed, 14 Aug 2019 10:13:48 -0700 > John Baldwin wrote: > >> On 8/14/19 9:22 AM, Ian Lepore wrote: >>> This all sounds vaguely wrong, backwards, to me. A developer who is >>> using a given module on their build system might want that module to be >>> rebuilt automatically, but only if the build parameters match those of >>> the running build host system. >>> >>> If my build host is running freebsd 12 amd64 and I'm doing a build for >>> freebsd 13 armv7, I have no interest in automatic rebuilds of an amd64 >>> driver module for a different OS arch and version just because that >>> module happens to be installed on the system I use to do crossbuilds. >>> >>> My objections are theoretical... this automation just seems improperly >>> designed to me. But it won't actually affect me in any way, because I >>> don't build video driver modules from ports, and I don't run freebsd >>> current on my build host machine. Probably the number of people doing >>> crossbuilding is small enough that nobody else is going to object to >>> this "the whole world is amd64" automation. >> >> You assume DRM is amd64-only when it is definitely not. It also has >> suitable guards in its Makefile to only build the relevant kernel >> modules on supported architectures. > > I clearly don't want to spend time to build the drm and radeon modules > when I'm hacking on arm64. > Shouldn't LOCAL_MODULE have ${TARGET}.${TARGET_ARCH} as a > subdirectory ? So when you install drm-kmod-* it will only install the > source in /usr/local/modules/${TARGET}.${TARGET_ARCH}/ ? (or whatever > the correct dir is). > I'm not sure what you're trying to accomplish. I might be misunderstanding completely, but, at least the drm ports have safeguards in their makefiles so they'll only be built for those arches where there is support, and only the modules needed, as an example, i915kms.ko will only be built on amd64 and i386, if that's what you're worried about. Regards -- Niclas Zeising