From owner-cvs-all@FreeBSD.ORG  Fri May 16 06:21:41 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8411237B401; Fri, 16 May 2003 06:21:41 -0700 (PDT)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 94EC643FA3; Fri, 16 May 2003 06:21:40 -0700 (PDT)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (localhost [127.0.0.1])
	by fledge.watson.org (8.12.9/8.12.9) with ESMTP id h4GDLOOn031170;
	Fri, 16 May 2003 09:21:24 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Received: from localhost (robert@localhost)h4GDLN7n031167;
	Fri, 16 May 2003 09:21:24 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Date: Fri, 16 May 2003 09:21:23 -0400 (EDT)
From: Robert Watson <rwatson@FreeBSD.org>
X-Sender: robert@fledge.watson.org
To: Kris Kennaway <kris@obsecurity.org>
In-Reply-To: <20030516021956.GA8711@rot13.obsecurity.org>
Message-ID: <Pine.NEB.3.96L.1030516092042.24024H-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 16 May 2003 13:21:42 -0000


On Thu, 15 May 2003, Kris Kennaway wrote:

> On Thu, May 15, 2003 at 06:13:17PM -0700, Robert Watson wrote:
> > rwatson     2003/05/15 18:13:17 PDT
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/dev/fxp          if_fxp.c 
> >   Log:
> >   Add a tunable/sysctl "hw.fxp_noflow" which disables flow control support
> >   on if_fxp cards.  When flow control is enabled, if the operating system
> >   doesn't acknowledge the packet buffer filling, the card will begin to
> >   generate ethernet quench packets, but appears to get into a feedback
> >   loop of some sort, hosing local switches.  This is a temporary workaround
> >   for 5.1: the ability to configure flow control should probably be
> >   exposed by some or another management interface on ethernet link layer
> >   devices.
> 
> Yay!  This periodically hosed one of my 4.x boxes until I added a hack
> from Peter to turn it off.  Can this be back-ported at some point? 

I imagine it would be a trivial backport, if no one else gets to it in a
day or two, I can do it this weekend.  It could be the patch would even
apply verbatim to RELENG_4 if the drivers are pretty in sync (which they
may well be).

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org      Network Associates Laboratories