From owner-freebsd-current Mon Nov 30 20:30:07 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id UAA10073 for freebsd-current-outgoing; Mon, 30 Nov 1998 20:30:07 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from lamb.sas.com (lamb.sas.com [192.35.83.8]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id UAA10065 for ; Mon, 30 Nov 1998 20:30:04 -0800 (PST) (envelope-from jwd@unx.sas.com) Received: from mozart (mozart.unx.sas.com [192.58.184.8]) by lamb.sas.com (8.9.1/8.9.1) with SMTP id XAA29871; Mon, 30 Nov 1998 23:29:48 -0500 (EST) Received: from bb01f39.unx.sas.com by mozart (5.65c/SAS/Domains/5-6-90) id AA26446; Mon, 30 Nov 1998 23:29:47 -0500 Received: (from jwd@localhost) by bb01f39.unx.sas.com (8.9.1/8.9.1) id XAA13377; Mon, 30 Nov 1998 23:29:47 -0500 (EST) (envelope-from jwd) From: "John W. DeBoskey" Message-Id: <199812010429.XAA13377@bb01f39.unx.sas.com> Subject: Re: mtree -d (diff to include symlinks) In-Reply-To: <19981201070708.A62426@nagual.pp.ru> from "Andrey A. Chernov" at "Dec 1, 98 07:07:08 am" To: ache@nagual.pp.ru (Andrey A. Chernov) Date: Mon, 30 Nov 1998 23:29:47 -0500 (EST) Cc: freebsd-current@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL38 (25)] Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Hi, From the commit logs: 1.7 Fri Jun 5 14:43:41 1998 UTC by peter ... I had created chown-style -L and -P flag to control logical/physical mode (ie: whether symlinks were followed), but the nochange flag is enough to get the blasted thing out of my hair so I took them back out. ... It looks like nothing was actually committed here: Or maybe I'm just lost... :-) ok, ok, the $Id line and the type of keys were changed... but I don't see any flags that have been added. Oh well, John =================================================================== RCS file: /home/ncvs/src/usr.sbin/mtree/mtree.c,v retrieving revision 1.6 retrieving revision 1.7 diff -p -u -r1.6 -r1.7 --- src/usr.sbin/mtree/mtree.c 1997/10/01 06:30:02 1.6 +++ /home/ncvs/src/usr.sbin/mtree/mtree.c 1998/06/05 14:43:41 1.7 @@ -42,7 +42,7 @@ static const char copyright[] = static char sccsid[] = "@(#)mtree.c 8.1 (Berkeley) 6/6/93"; #endif static const char rcsid[] = - "$Id: mtree.c,v 1.6 1997/10/01 06:30:02 charnier Exp $"; + "$Id: mtree.c,v 1.7 1998/06/05 14:43:41 peter Exp $"; #endif /* not lint */ #include @@ -59,7 +59,7 @@ extern long int crc_total; int ftsoptions = FTS_LOGICAL; int cflag, dflag, eflag, iflag, nflag, rflag, sflag, uflag, Uflag; -u_short keys; +u_int keys; char fullpath[MAXPATHLEN]; static void usage __P((void)); > On Mon, Nov 30, 1998 at 10:50:08PM -0500, John W. DeBoskey wrote: > > (See 1.3.8.3 Mon Mar 9 12:32:09 1998 UTC by ache) The > > comment does not say why the 'FTS_PHYSICAL -> FTS_LOGICAL' > > change was done. > > Because you got serious security hole in case you use symlinks to split > disk space on your system, imagine wrong /var/mail presmissions for > example. BTW I believe peter already commit the change which implements > (differently) what you want, see commit log for details. > > -- > Andrey A. Chernov > http://www.nagual.pp.ru/~ache/ > MTH/SH/HE S-- W-- N+ PEC>+ D A a++ C G>+ QH+(++) 666+>++ Y > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message