From owner-freebsd-usb@FreeBSD.ORG  Mon Feb 16 15:35:24 2009
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: usb@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5A096106566B;
	Mon, 16 Feb 2009 15:35:24 +0000 (UTC)
	(envelope-from thompsa@FreeBSD.org)
Received: from pele.citylink.co.nz (pele.citylink.co.nz [202.8.44.226])
	by mx1.freebsd.org (Postfix) with ESMTP id 16EAF8FC1C;
	Mon, 16 Feb 2009 15:35:23 +0000 (UTC)
	(envelope-from thompsa@FreeBSD.org)
Received: from localhost (localhost [127.0.0.1])
	by pele.citylink.co.nz (Postfix) with ESMTP id 41707FF41;
	Tue, 17 Feb 2009 04:35:23 +1300 (NZDT)
X-Virus-Scanned: Debian amavisd-new at citylink.co.nz
Received: from pele.citylink.co.nz ([127.0.0.1])
	by localhost (pele.citylink.co.nz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id mnuKxUsKrjIH; Tue, 17 Feb 2009 04:35:19 +1300 (NZDT)
Received: from citylink.fud.org.nz (unknown [202.8.44.45])
	by pele.citylink.co.nz (Postfix) with ESMTP;
	Tue, 17 Feb 2009 04:35:19 +1300 (NZDT)
Received: by citylink.fud.org.nz (Postfix, from userid 1001)
	id D8C431142E; Tue, 17 Feb 2009 04:35:19 +1300 (NZDT)
Date: Mon, 16 Feb 2009 07:35:19 -0800
From: Andrew Thompson <thompsa@FreeBSD.org>
To: Robert Watson <rwatson@FreeBSD.org>
Message-ID: <20090216153519.GB4723@citylink.fud.org.nz>
References: <alpine.BSF.2.00.0902161129060.5806@fledge.watson.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.BSF.2.00.0902161129060.5806@fledge.watson.org>
User-Agent: Mutt/1.5.17 (2007-11-01)
Cc: usb@FreeBSD.org, weongyo@FreeBSD.org,
	Hans Petter Selasky <hselasky@freebsd.org>
Subject: Re: USB support in NDIS -- IFF_NEEDSGIANT?
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Feb 2009 15:35:25 -0000

On Mon, Feb 16, 2009 at 11:33:18AM +0000, Robert Watson wrote:
> 
> Dear all:
> 
> As you know, I've been gradually working to eliminate all non-MPSAFE 
> network device driver infrastructure for 8.0, having removed non-MPSAFE 
> network protocol infrastructure in 7.0.  In reviewing remaining drivers 
> using IFF_NEEDSGIANT, I spotted this in the NDIS code:
> 
>   718         if_initname(ifp, device_get_name(dev), device_get_unit(dev));
>   719         ifp->if_mtu = ETHERMTU;
>   720         ifp->if_flags = IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST;
>   721         if (sc->ndis_iftype == PNPBus)
>   722                 ifp->if_flags |= IFF_NEEDSGIANT;
>   723         ifp->if_ioctl = ndis_ioctl;
>   724         ifp->if_start = ndis_start;
>   725         ifp->if_init = ndis_init;
> 
> Having taken a glance, it looks like this was added specifically to support 
> USB devices attached via NDIS.  With the new USB code, are NDIS drivers 
> still supported?  And in the new world order, is this IFF_NEEDSGIANT still 
> required? Can I simply remove it once the old USB code is on the way out 
> the door?
 
I had promised Weongyo that I would convert ndis to USB2 but have been a
bit busy. Anyone else welcome to pick this up in the mean time.

Andrew