From owner-freebsd-current@FreeBSD.ORG  Sun Apr 30 09:50:39 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 009C716A400
	for <freebsd-current@freebsd.org>; Sun, 30 Apr 2006 09:50:39 +0000 (UTC)
	(envelope-from marius.nuennerich@gmx.net)
Received: from mail.gmx.net (mail.gmx.net [213.165.64.20])
	by mx1.FreeBSD.org (Postfix) with SMTP id 06D4443D4C
	for <freebsd-current@freebsd.org>; Sun, 30 Apr 2006 09:50:37 +0000 (GMT)
	(envelope-from marius.nuennerich@gmx.net)
Received: (qmail invoked by alias); 30 Apr 2006 09:50:34 -0000
Received: from p50838B96.dip0.t-ipconnect.de (EHLO sol) [80.131.139.150]
	by mail.gmx.net (mp031) with SMTP; 30 Apr 2006 11:50:34 +0200
X-Authenticated: #5707313
Date: Sun, 30 Apr 2006 11:50:30 +0200
From: Marius Nuennerich <marius.nuennerich@gmx.net>
To: David Xu <davidxu@freebsd.org>
Message-ID: <20060430115030.69402983@sol>
In-Reply-To: <44547C85.7040107@freebsd.org>
References: <20060430115932.Y39336@is.park.rambler.ru>
	<44547C85.7040107@freebsd.org>
X-Mailer: Sylpheed-Claws 2.1.1 (GTK+ 2.8.17; i386-portbld-freebsd5.4)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Y-GMX-Trusted: 0
X-Mailman-Approved-At: Sun, 30 Apr 2006 11:45:36 +0000
Cc: Igor Sysoev <is@rambler-co.ru>, freebsd-current@freebsd.org
Subject: Re: FreeBSD-SA-06:14.fpu
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Apr 2006 09:50:39 -0000

On Sun, 30 Apr 2006 16:59:49 +0800
David Xu <davidxu@freebsd.org> wrote:

> Igor Sysoev wrote:
> > 
> > The last security advisory FreeBSD-SA-06:14.fpu
> > ftp://ftp.freebsd.org/pub/FreeBSD/CERT/advisories/FreeBSD-SA-06:14.fpu.asc
> > that fixes very doubtful security bug in AMD CPUs, also
> > adds unnecessary penalty in FPU context switch for all other
> > SSE-enabled CPUs.
> > 
> > 
> > Igor Sysoev
> > http://sysoev.ru/en/
> 
> Probably it should only be applied to AMD CPU but not Intel and others,
> it is easy to check cpu vendor and put a
> if (bug_fxsave)
> 	fpu_clean_state();
> 
> in file npx.c.
> 
> David Xu

Shouldn't we use an existing variable which is already in L1 instead of
the new dummy_variable? Or isn't this noticable in performance?

btw Linux does it this way:
> http://www.kernel.org/git/?p=linux/kernel/git/stable/linux-2.6.16.y.git;a=commitdiff;h=7466f9e72dac13452d871a3fb72fc7bd9c93c864

regards
Marius

P.S. I have no idea what variable we could use.