From owner-svn-src-all@FreeBSD.ORG Fri Sep 19 01:54:02 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 18BD1E20; Fri, 19 Sep 2014 01:54:02 +0000 (UTC) Received: from ns.kevlo.org (220-135-115-6.HINET-IP.hinet.net [220.135.115.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "ns.kevlo.org", Issuer "ns.kevlo.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id B140339F; Fri, 19 Sep 2014 01:54:01 +0000 (UTC) Received: from ns.kevlo.org (localhost [127.0.0.1]) by ns.kevlo.org (8.14.8/8.14.8) with ESMTP id s8J1qTdY012500 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 19 Sep 2014 09:52:30 +0800 (CST) (envelope-from kevlo@ns.kevlo.org) Received: (from kevlo@localhost) by ns.kevlo.org (8.14.8/8.14.8/Submit) id s8J1qTjU012499; Fri, 19 Sep 2014 09:52:29 +0800 (CST) (envelope-from kevlo) Date: Fri, 19 Sep 2014 09:52:28 +0800 From: Kevin Lo To: "Pedro F. Giffuni" Subject: Re: svn commit: r271792 - head/include Message-ID: <20140919015228.GA12490@ns.kevlo.org> References: <201409181718.s8IHIhNL052969@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201409181718.s8IHIhNL052969@svn.freebsd.org> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Sep 2014 01:54:02 -0000 On Thu, Sep 18, 2014 at 05:18:43PM +0000, Pedro F. Giffuni wrote: > > Author: pfg > Date: Thu Sep 18 17:18:42 2014 > New Revision: 271792 > URL: http://svnweb.freebsd.org/changeset/base/271792 > > Log: > unistd: move setpgrp(2) to the __BSD_VISIBLE section > > Our setpgrp(2) differs from the specified by POSIX, which > only has one argument, and is only meant for compatibility > with BSD. > > Reference: > http://pubs.opengroup.org/onlinepubs/009695399/functions/setpgrp.html > > Pointed-out in: openbsd-tech (2014-09-16) > MFC after: 6 weeks > > Modified: > head/include/unistd.h > > Modified: head/include/unistd.h > ============================================================================== > --- head/include/unistd.h Thu Sep 18 17:15:38 2014 (r271791) > +++ head/include/unistd.h Thu Sep 18 17:18:42 2014 (r271792) > @@ -453,7 +453,6 @@ int encrypt(char *, int); > long gethostid(void); > int lockf(int, int, off_t); > int nice(int); > -int setpgrp(pid_t _pid, pid_t _pgrp); /* obsoleted by setpgid() */ > int setregid(gid_t, gid_t); > int setreuid(uid_t, uid_t); > > @@ -567,6 +566,7 @@ int setkey(const char *); > int setlogin(const char *); > int setloginclass(const char *); > void *setmode(const char *); > +int setpgrp(pid_t _pid, pid_t _pgrp); /* obsoleted by setpgid() */ > void setproctitle(const char *_fmt, ...) __printf0like(1, 2); > int setresgid(gid_t, gid_t, gid_t); > int setresuid(uid_t, uid_t, uid_t); Since there are no prototypes in unistd.h include arguments, I'd be inclined to drop them for consistency. Kevin