From owner-cvs-all@FreeBSD.ORG Fri Mar 16 05:35:50 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9036C16A404 for ; Fri, 16 Mar 2007 05:35:50 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.226]) by mx1.freebsd.org (Postfix) with ESMTP id 45ADF13C45A for ; Fri, 16 Mar 2007 05:35:50 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: by wx-out-0506.google.com with SMTP id s18so443853wxc for ; Thu, 15 Mar 2007 22:35:49 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=Oi5NV2/SoSn+JTZ21lR+IzAD/x3CI4e9IQkagHSEiLdmszIgaJVlKbVJn4pv7hRbPTSaBud0aavwBa1D2JQo+qELHteBM+LWUeS5c0Tq5ZY8QniUbcxWBbsNaNHX+nWYhDz/6CT4Auuvau2aq7+0qEYfno7QSB+lp8yfjWzGNG4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=s/ztpDiFCohmxJGXOWpPBtSqNbBdQwIex36xaDR9iopu1VYPpIUv0zcbbrCASna6xCvk3gv9URfeyQ7aUF7FXkH+8rdA4Tq3Uqrl6zB6UPuv5PQeSTOz21wkPZ+Ii8YLZXwNDy8BjtGDNSDMvSMa1eLaLQZE8yezdWKIY7VGp/k= Received: by 10.90.101.19 with SMTP id y19mr1332677agb.1174023349577; Thu, 15 Mar 2007 22:35:49 -0700 (PDT) Received: by 10.90.25.1 with HTTP; Thu, 15 Mar 2007 22:35:49 -0700 (PDT) Message-ID: Date: Thu, 15 Mar 2007 22:35:49 -0700 From: "Kip Macy" To: roam@ringlet.net, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Cc: Subject: Re: cvs commit: src/share/man/man4 Makefile src/sys/dev/cxgb cxgb_adapter.h cxgb_config.h cxgb_ioctl.h cxgb_lro.c cxgb_main.c cxgb_osdep.h cxgb_sge.c t3fw-3.2.bin.gz.uu src/sys/dev/cxgb/common cxgb_ael1002.c cxgb_common.h cxgb_firmware_exports.h cxgb X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2007 05:35:50 -0000 I'm not saying it isn't a problem - but I can't reproduce it on my system. I see all sorts of inlining complaints from other modules but not cxgb. Are you sure you don't have a modified make.conf? -Kip On 3/15/07, Peter Pentchev wrote: > On Thu, 15 Mar 2007 at 03:06:32 +0000 (UTC), Kip Macy wrote: > > > > kmacy 2007-03-15 03:06:32 UTC > > > > FreeBSD src repository > > > > Modified files: (Branch: RELENG_6) > > share/man/man4 Makefile > > Added files: (Branch: RELENG_6) > > sys/dev/cxgb cxgb_adapter.h cxgb_config.h cxgb_ioctl.h > > cxgb_lro.c cxgb_main.c cxgb_osdep.h > > cxgb_sge.c t3fw-3.2.bin.gz.uu > > sys/dev/cxgb/common cxgb_ael1002.c cxgb_common.h > > cxgb_firmware_exports.h cxgb_mc5.c > > cxgb_mv88e1xxx.c cxgb_regs.h > > cxgb_sge_defs.h cxgb_t3_cpl.h > > cxgb_t3_hw.c cxgb_tcb.h cxgb_version.h > > cxgb_vsc8211.c cxgb_xgmac.c > > sys/modules/cxgb Makefile > > Log: > > MFC Chelsio T3 10 Gigabit Ethernet support > > > > Don't hook into build just > > Is it possible that the GCC version in 6.x-STABLE is different from > that in -CURRENT? On my laptop (i386, yesterday's -STABLE) LINT failed > to build with the following: > > /fs/6/usr.src/sys/dev/cxgb/cxgb_sge.c: In function `sge_timer_reclaim': > /fs/6/usr.src/sys/dev/cxgb/cxgb_sge.c:172: warning: inlining failed in call to 'refill_rspq': function body not available > /fs/6/usr.src/sys/dev/cxgb/cxgb_sge.c:699: warning: called from here > > It seems it simply needed refill_rspq() to be moved up, so that > the compiler could actually see the function body before first use; > or is this a bug in GCC? > > Anyway, here's a simple patch that fixed the LINT build for me. > > G'luck, > Peter > > Index: src/sys/dev/cxgb/cxgb_sge.c > =================================================================== > RCS file: /home/ncvs/src/sys/dev/cxgb/cxgb_sge.c,v > retrieving revision 1.2.2.1 > diff -u -r1.2.2.1 cxgb_sge.c > --- src/sys/dev/cxgb/cxgb_sge.c 15 Mar 2007 03:06:31 -0000 1.2.2.1 > +++ src/sys/dev/cxgb/cxgb_sge.c 15 Mar 2007 10:16:46 -0000 > @@ -640,6 +640,24 @@ > } > > > +/** > + * refill_rspq - replenish an SGE response queue > + * @adapter: the adapter > + * @q: the response queue to replenish > + * @credits: how many new responses to make available > + * > + * Replenishes a response queue by making the supplied number of responses > + * available to HW. > + */ > +static __inline void > +refill_rspq(adapter_t *sc, const struct sge_rspq *q, u_int credits) > +{ > + > + /* mbufs are allocated on demand when a rspq entry is processed. */ > + t3_write_reg(sc, A_SG_RSPQ_CREDIT_RETURN, > + V_RSPQ(q->cntxt_id) | V_CREDITS(credits)); > +} > + > static void > sge_timer_reclaim(void *arg, int ncount) > { > @@ -1562,23 +1580,6 @@ > } > > > -/** > - * refill_rspq - replenish an SGE response queue > - * @adapter: the adapter > - * @q: the response queue to replenish > - * @credits: how many new responses to make available > - * > - * Replenishes a response queue by making the supplied number of responses > - * available to HW. > - */ > -static __inline void > -refill_rspq(adapter_t *sc, const struct sge_rspq *q, u_int credits) > -{ > - > - /* mbufs are allocated on demand when a rspq entry is processed. */ > - t3_write_reg(sc, A_SG_RSPQ_CREDIT_RETURN, > - V_RSPQ(q->cntxt_id) | V_CREDITS(credits)); > -} > > /** > * free_tx_desc - reclaims Tx descriptors and their buffers > > -- > Peter Pentchev roam@ringlet.net roam@cnsys.bg roam@FreeBSD.org > PGP key: http://people.FreeBSD.org/~roam/roam.key.asc > Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 > I am the meaning of this sentence. > >