From owner-svn-src-head@freebsd.org  Mon Feb 13 12:04:51 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BB8AACDCC38;
 Mon, 13 Feb 2017 12:04:51 +0000 (UTC) (envelope-from marck@rinet.ru)
Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4B4CDB27;
 Mon, 13 Feb 2017 12:04:50 +0000 (UTC) (envelope-from marck@rinet.ru)
Received: from localhost (localhost [127.0.0.1])
 by woozle.rinet.ru (8.14.5/8.14.5) with ESMTP id v1DC4dpt056275;
 Mon, 13 Feb 2017 15:04:39 +0300 (MSK) (envelope-from marck@rinet.ru)
Date: Mon, 13 Feb 2017 15:04:39 +0300 (MSK)
From: Dmitry Morozovsky <marck@rinet.ru>
To: Glen Barber <gjb@freebsd.org>
cc: Cy Schubert <Cy.Schubert@komquats.com>,
 =?ISO-8859-15?Q?Ermal_Lu=E7i?= <eri@freebsd.org>,
 svn-src-head@freebsd.org, George Neville-Neil <gnn@neville-neil.com>,
 src-committers@freebsd.org, svn-src-all@freebsd.org
Subject: Re: svn commit: r313675 - in head/sys: netinet netinet6
In-Reply-To: <20170212183327.GA2002@FreeBSD.org>
Message-ID: <alpine.BSF.2.00.1702131504060.52731@woozle.rinet.ru>
References: <gnn@neville-neil.com>
 <53D3A92C-6C64-4C0C-A5E6-B659BFA139BF@neville-neil.com>
 <201702121624.v1CGOQGr009733@slippy.cwsent.com>
 <20170212183327.GA2002@FreeBSD.org>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
X-NCC-RegID: ru.rinet
X-OpenPGP-Key-ID: 6B691B03
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3
 (woozle.rinet.ru [0.0.0.0]); Mon, 13 Feb 2017 15:04:40 +0300 (MSK)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Feb 2017 12:04:51 -0000

On Sun, 12 Feb 2017, Glen Barber wrote:

[snip previous]

> > I didn't read this when I hit send on my email. Hopefully nobody takes 
> > offense. I was upset and still am.
> > 
> > I still think that the revision numbers of any backout should have been 
> > documented in the commit log.
> > 
> 
> I absolutely agree, and was the key meaning behind my "what exactly does
> this mean?" reply.  The commit log, as-is, provides nothing useful to
> the reader.
> 
> > Something we could do, as is expected by re@ for commits during a freeze, 
> > is metees also let their mentors know of what the contents of commit log 
> > messages will be. I think commit log messages discussing the what, why and 
> > rationale are as important as the code itself.
> > 
> 
> I thought this was standard practice.  But if not, I would agree that
> both code changes and the commit log should be both approved by the
> mentor.

Shouldn't we then emphacise this in the Committer's Guide?

-- 
Sincerely,
D.Marck                                     [DM5020, MCK-RIPE, DM3-RIPN]
[ FreeBSD committer:                                 marck@FreeBSD.org ]
------------------------------------------------------------------------
*** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru ***
------------------------------------------------------------------------