From owner-cvs-all Sun Mar 11 15:40:23 2001 Delivered-To: cvs-all@freebsd.org Received: from moby.geekhouse.net (moby.geekhouse.net [64.81.6.36]) by hub.freebsd.org (Postfix) with ESMTP id 5052C37B71B; Sun, 11 Mar 2001 15:40:14 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@dhcp152.geekhouse.net [192.168.1.152]) by moby.geekhouse.net (8.11.0/8.9.3) with ESMTP id f2BNfn157540; Sun, 11 Mar 2001 15:41:49 -0800 (PST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Sun, 11 Mar 2001 15:39:51 -0800 (PST) From: John Baldwin To: John Baldwin Subject: RE: cvs commit: src/sys/i386/linux linux_machdep.c Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Dag-Erling Smorgrav Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 11-Mar-01 John Baldwin wrote: > > On 11-Mar-01 Dag-Erling Smorgrav wrote: >> des 2001/03/11 10:52:11 PST >> >> Modified files: >> sys/i386/linux linux_machdep.c >> Log: >> rfork() masks RFSTOPPED out of the flags it passes to fork1(), so we have >> to call fork1() directly if we don't want out process queued right away. >> This has the serendipitous side effect of saving us a call to pfind(). >> >> This makes threaded Linux apps (such as Opera) work again. > > ... and breaks linux thread since we can send the wrong signal to them when > we > exit if enough bad things happen at the wrong times. After looking at > rfork() > which just calls fork1(), the proper fix would be to just call fork1() here, > not back it all out. And I should read diffs before sending mail so fast. The +4 -8 was deceptive. This patch should be applied to the alpha, too. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message