Date: Fri, 14 Aug 2015 12:44:04 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Alexander Motin <mav@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r286763 - in head/sys: cddl/contrib/opensolaris/uts/common cddl/contrib/opensolaris/uts/common/fs/zfs cddl/contrib/opensolaris/uts/common/fs/zfs/sys conf Message-ID: <55CDB864.7050100@FreeBSD.org> In-Reply-To: <55CDB802.9040507@FreeBSD.org> References: <201508140931.t7E9V8nF054188@repo.freebsd.org> <55CDB74F.6070708@FreeBSD.org> <55CDB802.9040507@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14/08/2015 12:42, Alexander Motin wrote: > On 14.08.2015 12:39, Andriy Gapon wrote: >> On 14/08/2015 12:31, Alexander Motin wrote: >>> Author: mav >>> Date: Fri Aug 14 09:31:07 2015 >>> New Revision: 286763 >>> URL: https://svnweb.freebsd.org/changeset/base/286763 >>> >>> Log: >>> MFV r277431: 5497 lock contention on arcs_mtx >>> >>> Reviewed by: George Wilson <george.wilson@delphix.com> >>> Reviewed by: Matthew Ahrens <mahrens@delphix.com> >>> Reviewed by: Richard Elling <richard.elling@richardelling.com> >>> Approved by: Dan McDonald <danmcd@omniti.com> >>> Author: Prakash Surya <prakash.surya@delphix.com> >>> >>> illumos/illumos-gate@244781f10dcd82684fd8163c016540667842f203 >>> >>> This patch attempts to reduce lock contention on the current arc_state_t >>> mutexes. These mutexes are used liberally to protect the number of LRU >>> lists within the ARC (e.g. ARC_mru, ARC_mfu, etc). The granularity at >>> which these locks are acquired has been shown to greatly affect the >>> performance of highly concurrent, cached workloads. >>> >>> Added: >>> head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/multilist.c (contents, props changed) >>> head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/multilist.h (contents, props changed) >>> Modified: >>> head/sys/cddl/contrib/opensolaris/uts/common/Makefile.files >>> head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c >>> head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_pool.c >>> head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/arc.h >>> head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zio_inject.c >>> head/sys/conf/files >>> Directory Properties: >>> head/sys/cddl/contrib/opensolaris/ (props changed) >>> >>> Modified: head/sys/cddl/contrib/opensolaris/uts/common/Makefile.files >>> ============================================================================== >>> --- head/sys/cddl/contrib/opensolaris/uts/common/Makefile.files Fri Aug 14 09:25:54 2015 (r286762) >>> +++ head/sys/cddl/contrib/opensolaris/uts/common/Makefile.files Fri Aug 14 09:31:07 2015 (r286763) >>> @@ -68,6 +68,7 @@ ZFS_COMMON_OBJS += \ >>> lz4.o \ >>> lzjb.o \ >>> metaslab.o \ >>> + multilist.o \ >>> range_tree.o \ >>> refcount.o \ >>> rrwlock.o \ >> >> Thank you! >> The new file also has to be added to sys/conf/files for those who >> compile ZFS into a kernel. > > And it was added just below. Have I missed something? > Oops, sorry for the noise. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55CDB864.7050100>