From owner-svn-src-all@freebsd.org Wed Oct 28 17:13:15 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 570EBA1E88D for ; Wed, 28 Oct 2015 17:13:15 +0000 (UTC) (envelope-from cemeyer@uw.edu) Received: from mail-pa0-x22f.google.com (mail-pa0-x22f.google.com [IPv6:2607:f8b0:400e:c03::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1EDDE18A5 for ; Wed, 28 Oct 2015 17:13:15 +0000 (UTC) (envelope-from cemeyer@uw.edu) Received: by pacfv9 with SMTP id fv9so12992026pac.3 for ; Wed, 28 Oct 2015 10:13:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uw_edu.20150623.gappssmtp.com; s=20150623; h=from:date:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=HXVBP2LXdmt5KhfIP7d2dwArRwEpGDcH5ObTF+dz8rM=; b=mnX9t3Jya7rnjG5qb/OLDI0aHNn1a9I8Go4RownBL2633CWc6tk6N9P+3B61kmN+iB Y/OEhtOyjP7vYDv5RqAe5EJph002d7H04qMDLXFzmU9tojyslcK2qH78h25XyvhFq2PP xuCQXHx34HQNG8i6KG3zOWHWCypMXZAS6acKQ6mIWSkFkaD/NZg5ynKjKZN5xX51hhkZ lkD59m42nY/Ep+W3hBJOSFBkqKZR75MH0xZzDahPPnuhESH9/3lj7wj906xQapEctDt9 xM7tGhHUswemWvrumVVG82ysIfTg/oFcuHD5mOBkDGoc3eQJ6Ysl7lrdvYU+r+hxmOPK VnqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=HXVBP2LXdmt5KhfIP7d2dwArRwEpGDcH5ObTF+dz8rM=; b=ZeKQNxjgEz3gvo4S/3wRtNrFGHJsRbxy3FrfajB40VYb65DFw9RD/v9/YF+0TSiAEP 4sG2Mlhkhd+FfbBmZDRweUIsY16Ru8AJSh6Fjl+SDaHXuw+xRINhLlk7mjrUUrR0cecT XTnGIcEp6DhWmrKgtevJ/NrQSM41SPMOGOVbGDHx0KVoulKl6PECifiT1v5070YvuZaa mgpfwxuZuEeL4E2ckzH+3WrYkffZIZxqBMwAFDcJymG/07KDF9Sjnq9Zzh+G0lAnuXlZ h1FfCTHrBkpjVe2eEoBqZM+1cC5gHr28Koj4C1Jsbj/tRmWNv7qFSucD5yFQDie6aoMZ bLAQ== X-Gm-Message-State: ALoCoQnO1hxq+tmT1EIi8GJdcV5ZzJ7LO6Lf4cbKrW43CD3dHtqmU8HPT70AXoe3qBnO2RQbJbOC X-Received: by 10.66.102.97 with SMTP id fn1mr34940610pab.77.1446052394651; Wed, 28 Oct 2015 10:13:14 -0700 (PDT) Received: from m (c-50-132-89-32.hsd1.wa.comcast.net. [50.132.89.32]) by smtp.gmail.com with ESMTPSA id w8sm46456478pbs.87.2015.10.28.10.13.12 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Oct 2015 10:13:13 -0700 (PDT) From: Conrad Meyer X-Google-Original-From: Conrad Meyer Date: Wed, 28 Oct 2015 10:13:11 -0700 To: Xin Li Cc: "Andrey A. Chernov" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290110 - in head: include lib/libc/stdio Message-ID: <20151028101311.34dfedb7@m> In-Reply-To: <5630EF2F.5080102@delphij.net> References: <201510281440.t9SEe2PR093917@repo.freebsd.org> <5630EF2F.5080102@delphij.net> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2015 17:13:15 -0000 On Wed, 28 Oct 2015 08:52:15 -0700 Xin Li wrote: > On 10/28/15 07:40, Andrey A. Chernov wrote: > > Add _flags2 per jhb@ suggestion since no room left in > > _flags. Rewrite O_APPEND flag checking using new __S2OAP > > flag. > > Is this ABI-safe? (I was somewhat surprised that struct > FILE is not opaque, which seems to be unavoidable because > some methods are traditionally macros that have direct > access to the members; the addition is done in the end of > the structure so it looks like the change is safe). It breaks anything that depends on the size of __sFILE (IMO dead code walking). Otherwise it should be ABI compatible, since the flags2 member is only added at the end. JHB has a patch floating around to remove all the FILE macros and re-private the contents of the FILE struct. As Bryan said already, Perl reaches in directly for the fd number and needs to be fixed before that can land. Best, Conrad